Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for infiltration function. #1578

Merged
merged 3 commits into from
Aug 17, 2023
Merged

Fix for infiltration function. #1578

merged 3 commits into from
Aug 17, 2023

Conversation

weilixu
Copy link
Collaborator

@weilixu weilixu commented Aug 16, 2023

No description provided.

@weilixu weilixu added the AppendixG Methods to enable the Appendix G model workflow label Aug 16, 2023
@weilixu weilixu requested a review from lymereJ August 16, 2023 20:34
lymereJ
lymereJ approved these changes Aug 16, 2023
View reviewed changes
Copy link
Collaborator

@lymereJ lymereJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good, I just left a few comments. I assume that the tests will pass so I'll approve but we should perhaps wait for the results before merging.

lib/openstudio-standards/standards/ashrae_90_1_prm/ashrae_90_1_prm_2019/ashrae_90_1_prm_2019.rb Outdated Show resolved Hide resolved
lib/openstudio-standards/utilities/assertion.rb Outdated Show resolved Hide resolved
lib/openstudio-standards/utilities/assertion.rb Outdated Show resolved Hide resolved
lib/openstudio-standards/standards/ashrae_90_1_prm/ashrae_90_1_prm.Model.rb Outdated Show resolved Hide resolved
@weilixu weilixu merged commit 6caa9e5 into AppendixG_Dev Aug 17, 2023
@weilixu weilixu deleted the appx_g/enhancement/apply_infiltration branch February 11, 2024 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lymereJ lymereJ lymereJ approved these changes

@mdahlhausen mdahlhausen mdahlhausen left review comments

Assignees
No one assigned
Labels
AppendixG Methods to enable the Appendix G model workflow
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@weilixu @mdahlhausen @lymereJ