Appx g/merge master 09192023 #1610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove Siz.AirLoopHVAC.rb and associated methods. These methods are now available in OpenStudio as of OpenStudio version 3.6.0.
remove Siz.CoilCoolingWater.rb and associated methods. These methods are now available in OpenStudio as of OpenStudio version 3.6.0.
remove Siz.HVACComponent.rb and associated methods. Only water heaters were using the feature. May consider generalizing if other components need it in the future.
remove Siz.HeatingCoolingFuels.rb and Siz.ThermalZone.rb and refactor associated methods. These methods are now available in OpenStudio as of OpenStudio version 3.6.0, under coolingFuelTypes, heatingFuelTypes, and appGHeatingFuelTypes
plant_loop_total_cooling_capacity is overloaded in the prm code and doesn't need to be
calculate fan power from existing field rather than relying on an sql file lookup
remove getAutosizedValueFromEquipmentSummary method from Siz.Model.rb
remove output fan report, which was only used for manually checking the older prm method
delete Siz.Model.rb and hvac_sizing directory
The original heatingDesignLoad and coolingDesignLoad method sin openstudio-standards were poorly named. They returned load density in w_per_m2 instead of w. Adjust the code to account for the w return from the new OpenStudio methods.
Apply Black to Python scripts
- remove references to runner and Os_Lib_HelperMethods - add tests
fix yard documentation
Feature/extension gem
…swt_redo Support to control supply water temperature based on outdoor air or zone demand for radiant system
rubocop autocorrect edits
…into appx_g/merge_master_09192023 # Conflicts: # lib/openstudio-standards/standards/Standards.Model.rb # lib/openstudio-standards/standards/ashrae_90_1_prm/ashrae_90_1_prm.AirLoopHVAC.rb # lib/openstudio-standards/standards/ashrae_90_1_prm/ashrae_90_1_prm.AirTerminalSingleDuctVAVReheat.rb # lib/openstudio-standards/standards/ashrae_90_1_prm/ashrae_90_1_prm.Model.rb
lymereJ
approved these changes
Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request overview
Merge master to Appendix_G to resolve conflicts.
Pull Request Author
bundle exec rake doc)bundle exec rake rubocop)requirestatements, ensure these are in core ruby or add to the gemspecReview Checklist
This will not be exhaustively relevant to every PR.