Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Appx g/feature/export user data partial #1611

Merged
merged 7 commits into from
Sep 21, 2023

Conversation

weilixu
Copy link
Collaborator

@weilixu weilixu commented Sep 19, 2023

Pull request overview

Add a function to generate user data template from a user model.

  • Fixes #ISSUENUMBERHERE (IF THIS IS A DEFECT)

Pull Request Author

  • Method changes or additions
  • Data changes or additions
  • Added tests for added methods
  • If methods have been deprecated, update rest of code to use the new methods
  • Documented new methods using yard syntax
  • Resolved yard documentation errors for new code (ran bundle exec rake doc)
  • Resolved rubocop syntax errors for new code (ran bundle exec rake rubocop)
  • All new and existing tests passes
  • If the code adds new require statements, ensure these are in core ruby or add to the gemspec

Review Checklist

This will not be exhaustively relevant to every PR.

  • Perform a code review on GitHub
  • All related changes have been implemented: method additions, changes, tests
  • Check rubocop errors
  • Check yard doc errors
  • If fixing a defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If a new feature, test the new feature and try creative ways to break it
  • CI status: all green or justified

@weilixu weilixu added the AppendixG Methods to enable the Appendix G model workflow label Sep 19, 2023
@weilixu weilixu requested a review from lymereJ September 19, 2023 18:04
@weilixu weilixu self-assigned this Sep 19, 2023
@weilixu weilixu merged commit e843556 into AppendixG_Dev Sep 21, 2023
@weilixu weilixu mentioned this pull request Sep 22, 2023
16 tasks
@weilixu weilixu deleted the appx_g/feature/export_user_data_partial branch February 11, 2024 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AppendixG Methods to enable the Appendix G model workflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants