Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise boiler effeciency ECM for primary or secondary #1628

Merged
merged 1 commit into from
Oct 24, 2023
Merged

Conversation

ckirney
Copy link
Collaborator

@ckirney ckirney commented Oct 24, 2023

…s a primary or secondary boiler in the name.

Pull request overview

  • Fixes #ISSUENUMBERHERE (IF THIS IS A DEFECT)

Pull Request Author

  • Method changes or additions
  • Data changes or additions
  • Added tests for added methods
  • If methods have been deprecated, update rest of code to use the new methods
  • Documented new methods using yard syntax
  • Resolved yard documentation errors for new code (ran bundle exec rake doc)
  • Resolved rubocop syntax errors for new code (ran bundle exec rake rubocop)
  • All new and existing tests passes
  • If the code adds new require statements, ensure these are in core ruby or add to the gemspec

Review Checklist

This will not be exhaustively relevant to every PR.

  • Perform a code review on GitHub
  • All related changes have been implemented: method additions, changes, tests
  • Check rubocop errors
  • Check yard doc errors
  • If fixing a defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If a new feature, test the new feature and try creative ways to break it
  • CI status: all green or justified

…s a primary or secondary boiler in the name.
@ckirney ckirney merged commit 93eac67 into nrcan Oct 24, 2023
1 of 2 checks passed
@mdahlhausen mdahlhausen changed the title Revising boiler efficiency update ECM to properly include if boiler i… Revise boiler effeciency ECM for primary or secondary Apr 9, 2024
@ckirney ckirney deleted the nrcan_hvac_test branch August 21, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant