Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Uniform Energy Factor conversion #1633

Merged
merged 8 commits into from
Dec 9, 2023
Merged

Add Uniform Energy Factor conversion #1633

merged 8 commits into from
Dec 9, 2023

Commits on Oct 30, 2023

  1. Add UEF to EF conversion.

    @lymereJ
    lymereJ committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    024a657 View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2023

  1. Missing argument.

    @lymereJ
    lymereJ committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    eb11c9f View commit details
    Browse the repository at this point in the history

Commits on Nov 30, 2023

  1. Address issues with arguments.

    @lymereJ
    lymereJ committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    45988a5 View commit details
    Browse the repository at this point in the history

  2. Add tests, misc formatting changes.

    @lymereJ
    lymereJ committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    0617e1d View commit details
    Browse the repository at this point in the history

  3. Fix typos.

    @lymereJ
    lymereJ committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    db682f7 View commit details
    Browse the repository at this point in the history

Commits on Dec 1, 2023

  1. Missing argument.

    @lymereJ
    lymereJ committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    c3bd16b View commit details
    Browse the repository at this point in the history

Commits on Dec 2, 2023

  1. Fix typo.

    @lymereJ
    lymereJ committed Dec 2, 2023
    Configuration menu
    Copy the full SHA
    68c3136 View commit details
    Browse the repository at this point in the history

Commits on Dec 9, 2023

  1. use descriptive water heater variable names 

    rubocop suggested changing ef to energy _factor.

descriptive name changes:
ef -> energy_factor
uef -> uniform_energy_factor
water_heater_eff -> water_heater_efficiency
re -> recovery_efficiency
    @mdahlhausen
    mdahlhausen committed Dec 9, 2023
    Configuration menu
    Copy the full SHA
    093050e View commit details
    Browse the repository at this point in the history