Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nrcan issue 408 Exclude district heating and cooling from EUI for GSHP #1642

Merged
merged 3 commits into from
Nov 27, 2023

Conversation

srgilani
Copy link
Collaborator

Pull request overview

  • Fixes #ISSUENUMBERHERE (IF THIS IS A DEFECT)

Pull Request Author

  • Method changes or additions
  • Data changes or additions
  • Added tests for added methods
  • If methods have been deprecated, update rest of code to use the new methods
  • Documented new methods using yard syntax
  • Resolved yard documentation errors for new code (ran bundle exec rake doc)
  • Resolved rubocop syntax errors for new code (ran bundle exec rake rubocop)
  • All new and existing tests passes
  • If the code adds new require statements, ensure these are in core ruby or add to the gemspec

Review Checklist

This will not be exhaustively relevant to every PR.

  • Perform a code review on GitHub
  • All related changes have been implemented: method additions, changes, tests
  • Check rubocop errors
  • Check yard doc errors
  • If fixing a defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If a new feature, test the new feature and try creative ways to break it
  • CI status: all green or justified

…e district heating and cooling from total EUI and heating and cooling EUI when the HVAC system is GSHP
@srgilani srgilani merged commit 0dfa573 into nrcan Nov 27, 2023
0 of 2 checks passed
@srgilani srgilani deleted the nrcan_408 branch November 29, 2023 19:49
@mdahlhausen mdahlhausen changed the title nrcan_408: Exclude district heating and cooling from EUI for GSHP Nrcan issue 408 Exclude district heating and cooling from EUI for GSHP Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant