Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PVAV gas enumerations #1651

Merged
merged 1 commit into from
Jan 4, 2024
Merged

Add PVAV gas enumerations #1651

merged 1 commit into from
Jan 4, 2024

Conversation

mdahlhausen
Copy link
Collaborator

@mdahlhausen mdahlhausen commented Jan 3, 2024 •
edited
Loading

Pull request overview

add enumerations for PVAV gas systems

Pull Request Author

  • Method changes or additions
  • All new and existing tests passes

Review Checklist

This will not be exhaustively relevant to every PR.

  • Perform a code review on GitHub
  • All related changes have been implemented: method additions, changes, tests
  • Check rubocop errors
  • Check yard doc errors
  • If fixing a defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If a new feature, test the new feature and try creative ways to break it
  • CI status: all green or justified

@mdahlhausen mdahlhausen merged commit 0b9ac97 into master Jan 4, 2024
1 of 2 checks passed
@mdahlhausen mdahlhausen deleted the fix/pvav_gas branch January 4, 2024 17:28
@eringold eringold restored the fix/pvav_gas branch January 8, 2024 16:30
@mdahlhausen mdahlhausen changed the title add pvav gas enumerations Add PVAV gas enumerations Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mdahlhausen