New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect vestibule floor area check #1662

Merged

mdahlhausen merged 1 commit into master from fix/issue1554

Jan 13, 2024

Collaborator

mdahlhausen commented Jan 12, 2024 •

edited

Loading

Pull request overview

fix incorrect vestibule floor area check

Fixes thermal_zone_vestibule? ... > 200 ft2? #1554

Pull Request Author

Method changes or additions
Resolved yard documentation errors for new code (ran bundle exec rake doc)
Resolved rubocop syntax errors for new code (ran bundle exec rake rubocop)
All new and existing tests passes

Review Checklist

This will not be exhaustively relevant to every PR.

Perform a code review on GitHub
All related changes have been implemented: method additions, changes, tests
Check rubocop errors
Check yard doc errors
CI status: all green or justified


          fix incorrect vestibule floor area check

9b80a1f

mdahlhausen merged commit 6823afd into master

1 of 2 checks passed

mdahlhausen deleted the fix/issue1554 branch

January 13, 2024 16:37

mdahlhausen changed the title ~~fix incorrect vestibule floor area check~~ Fix incorrect vestibule floor area check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet