Updating CWEC2020 weather data and including ability to use HDD from either weather file or NECB #1666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove Siz.HVACComponent.rb and associated methods. Only water heaters were using the feature. May consider generalizing if other components need it in the future.
Merge changes in master into nrcan_master_merge branch.
remove Siz.HeatingCoolingFuels.rb and Siz.ThermalZone.rb and refactor associated methods. These methods are now available in OpenStudio as of OpenStudio version 3.6.0, under coolingFuelTypes, heatingFuelTypes, and appGHeatingFuelTypes
plant_loop_total_cooling_capacity is overloaded in the prm code and doesn't need to be
calculate fan power from existing field rather than relying on an sql file lookup
remove getAutosizedValueFromEquipmentSummary method from Siz.Model.rb
remove output fan report, which was only used for manually checking the older prm method
delete Siz.Model.rb and hvac_sizing directory
identical to air_loop_hvac_multizone_vav_optimization_required? in Standards.AirLoopHVAC.rb
identical to air_loop_hvac_set_vsd_curve_type in Standards.AirLoopHVAC.rb
identical to model_baseline_system_vav_fan_type in ashrae_90_1_prm.Model.rb
The return value is the same throughout the code base, except for an Xcel program override. We can break this out into a method again if other standards require it.
ashrae_90_1_prm_2019 duplicates the method in ashrae_90_1_prm also remove the Xcel and custom argument reference from the base method
returns the same values as boiler_hot_water_find_search_criteria in Standards.BoilerHotWater.rb
duplicate of coil_heating_gas_find_capacity in Standards.CoilHeatingGas.rb
duplicate of boiler_hot_water_standard_minimum_thermal_efficiency in Standards.BoilerHotWater.rb
Fix inheritance
remove duplicated method model_prm_baseline_system_number in ashrae_90_1_prm_2019 that is already in ashrae_90_1_prm
this is duplicate of cooling_tower_apply_minimum_power_per_flow in Standards.CoolingTower.rb Note the 'fan_type' is defined as 'Propeller or Axial' in Standards.CoolingTower.rb, and 'Axial' in the PRM version. The PRM data should switch to 'Propeller or Axial' to align with 90.1.
duplicate of chiller_electric_eir_standard_minimum_full_load_efficiency in Standards.ChillerElectricEIR.rb. The returns were changed for setting the chiller name and logging. Add calls to get those variables.
Remove duplicate prm method chiller_electric_eir_find_search_criteria which is already defined in Standards.ChillerElectricEIR.rb. The PRM method looks up the compressor type by an additional features property on the chiller object. Adjust the Standards method to check for compressor_type in chiller additional properties before inferring from the chiller name.
Updating license from LGBL to BSD to match OpenStudio, ext gem, and m…
Remove timestep interpolation from process_hrs_of_operation_hash
Updating nrcan_master_merge branch from master
Update from nrcan branch
…g 'With_Processing' weather data from /data/weather/ folder since it is no longer used.
…e appropriate arguments.
…d results file and adding the test to ci_tests.txt.
…d18 method using the updated argument types.
Added LEEP openstudio geometry files.
Added standard building name to LEEP OSM files (#1663)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request overview
Pull Request Author
bundle exec rake doc)bundle exec rake rubocop)requirestatements, ensure these are in core ruby or add to the gemspecReview Checklist
This will not be exhaustively relevant to every PR.