Building Energy Standards Water Heater Data Update #1680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lymereJ
changed the title
|
All the non-NECB tests should now pass. The DOE prototype performance tests and regression models had to be regenerated for the following reasons:
|
lymereJ
reviewed
Apr 1, 2024
Comment on lines
-127
to
+130
| hrly_loss_pct = hr_loss_base + (hr_loss_allow / volume_gal) / 100.0 | ||
| hrly_loss_pct = hr_loss_base + hr_loss_allow / volume_gal | ||
| # Convert to Btu/hr, assuming: | ||
| # Water at 120F, density = 8.25 lb/gal | ||
| # 1 Btu to raise 1 lb of water 1 F | ||
| # Therefore 8.25 Btu / gal of water * deg F | ||
| # 70F delta-T between water and zone | ||
| hrly_loss_btu_per_hr = hrly_loss_pct * volume_gal * 8.25 * 70 | ||
| hrly_loss_btu_per_hr = (hrly_loss_pct / 100) * volume_gal * 8.25 * 70 |
There was a problem hiding this comment.
The / 100 should be applied to hrly_loss_pct, not just to hr_loss_allow, otherwise hr_loss_base gets ignored and hrly_loss_btu_per_hr are overestimated.
lymereJ
reviewed
Apr 1, 2024
| @@ -2423,6 +2426,48 @@ def model_find_objects(hash_of_objects, search_criteria, capacity = nil, date = | |||
| end | |||
| end | |||
|
|
|||
| # If volume was specified, narrow down the matching objects | |||
| unless volume.nil? | |||
There was a problem hiding this comment.
Consider storage volume as a lookup key.
lymereJ
reviewed
Apr 1, 2024
| end | ||
|
|
||
| # If capacity_per_volume was specified, narrow down the matching objects | ||
| unless capacity_per_volume.nil? |
There was a problem hiding this comment.
Consider the ratio of capacity per volume as a lookup key.
lymereJ
reviewed
Apr 1, 2024
Comment on lines
+220
to
+246
| if wh_props_capacity.size == 1 | ||
| wh_props = wh_props_capacity[0] | ||
| elsif wh_props_capacity_and_volume.size == 1 | ||
| wh_props = wh_props_capacity_and_volume[0] | ||
| elsif wh_props_capacity_and_capacity_btu_per_hr == 1 | ||
| wh_props = wh_props_capacity_and_capacity_btu_per_hr[0] | ||
| elsif wh_props_capacity_and_volume_and_capacity_per_volume == 1 | ||
| wh_props = wh_props_capacity_and_volume_and_capacity_per_volume[0] | ||
| else | ||
| # Search again with additional criteria | ||
| search_criteria = water_heater_mixed_additional_search_criteria(water_heater_mixed, search_criteria) | ||
| wh_props_capacity = model_find_objects(standards_data['water_heaters'], search_criteria, capacity_btu_per_hr) | ||
| wh_props_capacity_and_volume = model_find_objects(standards_data['water_heaters'], search_criteria, capacity_btu_per_hr, nil, nil, nil, nil, volume_gal.round(0)) | ||
| wh_props_capacity_and_capacity_btu_per_hr = model_find_objects(standards_data['water_heaters'], search_criteria, capacity_btu_per_hr, nil, nil, nil, nil, nil, capacity_btu_per_hr) | ||
| wh_props_capacity_and_volume_and_capacity_per_volume = model_find_objects(standards_data['water_heaters'], search_criteria, capacity_btu_per_hr, nil, nil, nil, nil, volume_gal, capacity_btu_per_hr / volume_gal) | ||
| if wh_props_capacity.size == 1 | ||
| wh_props = wh_props_capacity[0] | ||
| elsif wh_props_capacity_and_volume.size == 1 | ||
| wh_props = wh_props_capacity_and_volume[0] | ||
| elsif wh_props_capacity_and_capacity_btu_per_hr == 1 | ||
| wh_props = wh_props_capacity_and_capacity_btu_per_hr[0] | ||
| elsif wh_props_capacity_and_volume_and_capacity_per_volume == 1 | ||
| wh_props = wh_props_capacity_and_volume_and_capacity_per_volume[0] | ||
| else | ||
| return {} | ||
| end | ||
| end |
There was a problem hiding this comment.
Use a "stepped" approach to identify what the applicable requirement should be.
lymereJ
reviewed
Apr 1, 2024
| require_relative '../helpers/minitest_helper' | ||
|
|
||
| class TestSpaceType < Minitest::Test | ||
| def test_water_heater_efficiency_lookup |
There was a problem hiding this comment.
Add basic efficiency lookup test for water heater.
mdahlhausen
approved these changes
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates have been made to the Building Energy Standards Data repository, see here. This pull request was automatically generated.