Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue nrcan_414 re NV #1684

Merged
merged 1 commit into from
Feb 12, 2024
Merged

Fix issue nrcan_414 re NV #1684

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
152 changes: 78 additions & 74 deletions lib/openstudio-standards/standards/necb/ECMS/nv.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,84 +90,88 @@ def apply_nv(model:, nv_type:, nv_opening_fraction:, nv_temp_out_min:, nv_delta_
min_Tin_schedule_defaultDay.addValue(time, min_Tin_schedule_defaultDay_values_adjusted[i])
i += 1.0
end
end
end
end

##### Calculate how many windows a space has.
# The total number of windows is used to divide OA/person and OA/FloorArea of the space by it (i.e. number of windows).
# In this way, NV-driven OA in each space would be avoided to be more than required.
space.surfaces.sort.each do |surface|
surface.subSurfaces.sort.each do |subsurface|
if (subsurface.subSurfaceType == 'OperableWindow' || subsurface.subSurfaceType == 'FixedWindow') && subsurface.outsideBoundaryCondition == 'Outdoors'
number_of_windows += 1.0
end
end
end
oa_per_person_normalized_by_number_of_windows = outdoor_air_flow_per_person / number_of_windows
oa_per_floor_area_normalized_by_number_of_windows = outdoor_air_flow_per_floor_area / number_of_windows

##### Add NV in each space that has window(s) using two objects: "ZoneVentilation:DesignFlowRate" and "ZoneVentilation:WindandStackOpenArea"
space.surfaces.sort.each do |surface|
surface.subSurfaces.sort.each do |subsurface|
if (subsurface.subSurfaceType == 'OperableWindow' || subsurface.subSurfaceType == 'FixedWindow') && subsurface.outsideBoundaryCondition == 'Outdoors'
window_azimuth_deg = OpenStudio.convert(subsurface.azimuth, 'rad', 'deg').get
window_area = subsurface.netArea

##### Define a constant schedule for operable windows
operable_window_schedule = OpenStudio::Model::ScheduleConstant.new(model)
operable_window_schedule.setName('operable_window_schedule_constant')
operable_window_schedule.setScheduleTypeLimits(BTAP::Resources::Schedules::StandardScheduleTypeLimits.get_on_off(model))

##### Add a "ZoneVentilation:DesignFlowRate" object for NV to set OA per person.
zn_vent_design_flow_rate_1 = OpenStudio::Model::ZoneVentilationDesignFlowRate.new(model)
zn_vent_design_flow_rate_1.setFlowRateperPerson(oa_per_person_normalized_by_number_of_windows)
if model.version < OpenStudio::VersionString.new('3.5.0')
# Design Flow Rate Calculation Method is automatically set in 3.5.0+
zn_vent_design_flow_rate_1.setDesignFlowRateCalculationMethod('Flow/Person')
end
zn_vent_design_flow_rate_1.setVentilationType('Natural')
zn_vent_design_flow_rate_1.setMinimumIndoorTemperatureSchedule(min_Tin_schedule)
zn_vent_design_flow_rate_1.setMaximumIndoorTemperatureSchedule(max_Tin_schedule)
zn_vent_design_flow_rate_1.setMinimumOutdoorTemperature(nv_temp_out_min)
zn_vent_design_flow_rate_1.setMaximumOutdoorTemperatureSchedule(max_Tin_schedule)
zn_vent_design_flow_rate_1.setDeltaTemperature(nv_delta_temp_in_out) # E+ I/O Ref.: "This is the temperature difference between the indoor and outdoor air dry-bulb temperatures below which ventilation is shutoff."
zone_hvac_equipment_list.addEquipment(zn_vent_design_flow_rate_1)

##### Add another "ZoneVentilation:DesignFlowRate" object for NV to set OA per floor area.
zn_vent_design_flow_rate_2 = OpenStudio::Model::ZoneVentilationDesignFlowRate.new(model)
zn_vent_design_flow_rate_2.setFlowRateperZoneFloorArea(oa_per_floor_area_normalized_by_number_of_windows)
if model.version < OpenStudio::VersionString.new('3.5.0')
# Design Flow Rate Calculation Method is automatically set in 3.5.0+
zn_vent_design_flow_rate_2.setDesignFlowRateCalculationMethod('Flow/Area')

##### Calculate how many windows a space has.
# The total number of windows is used to divide OA/person and OA/FloorArea of the space by it (i.e. number of windows).
# In this way, NV-driven OA in each space would be avoided to be more than required.
space.surfaces.sort.each do |surface|
surface.subSurfaces.sort.each do |subsurface|
if (subsurface.subSurfaceType == 'OperableWindow' || subsurface.subSurfaceType == 'FixedWindow') && subsurface.outsideBoundaryCondition == 'Outdoors'
number_of_windows += 1.0
end
end
end
zn_vent_design_flow_rate_2.setVentilationType('Natural')
zn_vent_design_flow_rate_2.setMinimumIndoorTemperatureSchedule(min_Tin_schedule)
zn_vent_design_flow_rate_2.setMaximumIndoorTemperatureSchedule(max_Tin_schedule)
zn_vent_design_flow_rate_2.setMinimumOutdoorTemperature(nv_temp_out_min)
zn_vent_design_flow_rate_2.setMaximumOutdoorTemperatureSchedule(max_Tin_schedule)
zn_vent_design_flow_rate_2.setDeltaTemperature(nv_delta_temp_in_out)
zone_hvac_equipment_list.addEquipment(zn_vent_design_flow_rate_2)

##### Add the "ZoneVentilation:WindandStackOpenArea" for NV.
# Note: it has been assumed that 'Opening Effectiveness' and 'Discharge Coefficient for Opening' are autocalculated (which are the default assumptions).
zn_vent_wind_and_stack = OpenStudio::Model::ZoneVentilationWindandStackOpenArea.new(model)
zn_vent_wind_and_stack.setOpeningArea(window_area * nv_opening_fraction)
zn_vent_wind_and_stack.setOpeningAreaFractionSchedule(operable_window_schedule)
# (Ref: E+ I/O) The Effective Angle value "is used to calculate the angle between the wind direction and the opening outward normal to determine the opening effectiveness values when the input field Opening Effectiveness = Autocalculate."
# (Ref: E+ I/O) "Effective Angle is the angle in degrees counting from the North clockwise to the opening outward normal."
zn_vent_wind_and_stack.setEffectiveAngle(window_azimuth_deg)
zn_vent_wind_and_stack.setMinimumIndoorTemperatureSchedule(min_Tin_schedule)
zn_vent_wind_and_stack.setMaximumIndoorTemperatureSchedule(max_Tin_schedule)
zn_vent_wind_and_stack.setMinimumOutdoorTemperature(nv_temp_out_min)
zn_vent_wind_and_stack.setMaximumOutdoorTemperatureSchedule(max_Tin_schedule)
zn_vent_wind_and_stack.setDeltaTemperature(nv_delta_temp_in_out)
zone_hvac_equipment_list.addEquipment(zn_vent_wind_and_stack)
# if (subsurface.subSurfaceType == 'OperableWindow' || subsurface.subSurfaceType == 'FixedWindow') && subsurface.outsideBoundaryCondition == 'Outdoors'
oa_per_person_normalized_by_number_of_windows = outdoor_air_flow_per_person / number_of_windows
oa_per_floor_area_normalized_by_number_of_windows = outdoor_air_flow_per_floor_area / number_of_windows

##### Add NV in each space that has window(s) using two objects: "ZoneVentilation:DesignFlowRate" and "ZoneVentilation:WindandStackOpenArea"
space.surfaces.sort.each do |surface|
surface.subSurfaces.sort.each do |subsurface|
if (subsurface.subSurfaceType == 'OperableWindow' || subsurface.subSurfaceType == 'FixedWindow') && subsurface.outsideBoundaryCondition == 'Outdoors'
window_azimuth_deg = OpenStudio.convert(subsurface.azimuth, 'rad', 'deg').get
window_area = subsurface.netArea

##### Define a constant schedule for operable windows
operable_window_schedule = OpenStudio::Model::ScheduleConstant.new(model)
operable_window_schedule.setName('operable_window_schedule_constant')
operable_window_schedule.setScheduleTypeLimits(BTAP::Resources::Schedules::StandardScheduleTypeLimits.get_on_off(model))

##### Add a "ZoneVentilation:DesignFlowRate" object for NV to set OA per person.
zn_vent_design_flow_rate_1 = OpenStudio::Model::ZoneVentilationDesignFlowRate.new(model)
zn_vent_design_flow_rate_1.setFlowRateperPerson(oa_per_person_normalized_by_number_of_windows)
if model.version < OpenStudio::VersionString.new('3.5.0')
# Design Flow Rate Calculation Method is automatically set in 3.5.0+
zn_vent_design_flow_rate_1.setDesignFlowRateCalculationMethod('Flow/Person')
end
zn_vent_design_flow_rate_1.setVentilationType('Natural')
zn_vent_design_flow_rate_1.setMinimumIndoorTemperatureSchedule(min_Tin_schedule)
zn_vent_design_flow_rate_1.setMaximumIndoorTemperatureSchedule(max_Tin_schedule)
zn_vent_design_flow_rate_1.setMinimumOutdoorTemperature(nv_temp_out_min)
zn_vent_design_flow_rate_1.setMaximumOutdoorTemperatureSchedule(max_Tin_schedule)
zn_vent_design_flow_rate_1.setDeltaTemperature(nv_delta_temp_in_out) # E+ I/O Ref.: "This is the temperature difference between the indoor and outdoor air dry-bulb temperatures below which ventilation is shutoff."
zone_hvac_equipment_list.addEquipment(zn_vent_design_flow_rate_1)

##### Add another "ZoneVentilation:DesignFlowRate" object for NV to set OA per floor area.
zn_vent_design_flow_rate_2 = OpenStudio::Model::ZoneVentilationDesignFlowRate.new(model)
zn_vent_design_flow_rate_2.setFlowRateperZoneFloorArea(oa_per_floor_area_normalized_by_number_of_windows)
if model.version < OpenStudio::VersionString.new('3.5.0')
# Design Flow Rate Calculation Method is automatically set in 3.5.0+
zn_vent_design_flow_rate_2.setDesignFlowRateCalculationMethod('Flow/Area')
end
zn_vent_design_flow_rate_2.setVentilationType('Natural')
zn_vent_design_flow_rate_2.setMinimumIndoorTemperatureSchedule(min_Tin_schedule)
zn_vent_design_flow_rate_2.setMaximumIndoorTemperatureSchedule(max_Tin_schedule)
zn_vent_design_flow_rate_2.setMinimumOutdoorTemperature(nv_temp_out_min)
zn_vent_design_flow_rate_2.setMaximumOutdoorTemperatureSchedule(max_Tin_schedule)
zn_vent_design_flow_rate_2.setDeltaTemperature(nv_delta_temp_in_out)
zone_hvac_equipment_list.addEquipment(zn_vent_design_flow_rate_2)

##### Add the "ZoneVentilation:WindandStackOpenArea" for NV.
# Note: it has been assumed that 'Opening Effectiveness' and 'Discharge Coefficient for Opening' are autocalculated (which are the default assumptions).
zn_vent_wind_and_stack = OpenStudio::Model::ZoneVentilationWindandStackOpenArea.new(model)
zn_vent_wind_and_stack.setOpeningArea(window_area * nv_opening_fraction)
zn_vent_wind_and_stack.setOpeningAreaFractionSchedule(operable_window_schedule)
# (Ref: E+ I/O) The Effective Angle value "is used to calculate the angle between the wind direction and the opening outward normal to determine the opening effectiveness values when the input field Opening Effectiveness = Autocalculate."
# (Ref: E+ I/O) "Effective Angle is the angle in degrees counting from the North clockwise to the opening outward normal."
zn_vent_wind_and_stack.setEffectiveAngle(window_azimuth_deg)
zn_vent_wind_and_stack.setMinimumIndoorTemperatureSchedule(min_Tin_schedule)
zn_vent_wind_and_stack.setMaximumIndoorTemperatureSchedule(max_Tin_schedule)
zn_vent_wind_and_stack.setMinimumOutdoorTemperature(nv_temp_out_min)
zn_vent_wind_and_stack.setMaximumOutdoorTemperatureSchedule(max_Tin_schedule)
zn_vent_wind_and_stack.setDeltaTemperature(nv_delta_temp_in_out)
zone_hvac_equipment_list.addEquipment(zn_vent_wind_and_stack)
# if (subsurface.subSurfaceType == 'OperableWindow' || subsurface.subSurfaceType == 'FixedWindow') && subsurface.outsideBoundaryCondition == 'Outdoors'
end
# surface.subSurfaces.sort.each do |subsurface|
end
# space.surfaces.sort.each do |surface|

end
# surface.subSurfaces.sort.each do |subsurface|
end
# space.surfaces.sort.each do |surface|
end


end
# thermal_zone.spaces.sort.each do |space|
end
Expand Down