Add schedule type limit to simple schedule adjustment #1686
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add schedule limit type to ruleset schedule simple value adjustment to prevent simulation errors that the schedule value over the lower or upper boundary.
Pull request overview
We are refactoring some PRM functions using the new schedule modules while reducing the size the test cases as discussed in the last call.
The issue this PR is addressing is when using the
schedule_ruleset_simple_value_adjust
, it does not set a limit following thescheduleTypeLimits
, which could cause severe simulation errors when the adjusted schedule value goes beyond the limit. The suggested change is to add this limitations to the function.Pull Request Author
bundle exec rake doc
)bundle exec rake rubocop
)require
statements, ensure these are in core ruby or add to the gemspecReview Checklist
This will not be exhaustively relevant to every PR.