-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add HVAC zone mapping to create typical #1693
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…al_building_from_model measure
@mdahlhausen - This is work that @jugonzal07 has been doing as part of this OS measure. |
mdahlhausen
approved these changes
Apr 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks for adding this functionality.
I added a sizing run location to the create typical method, updated from master, and made a few rubocop edits.
mdahlhausen
changed the title
Hvac zone mapping added for create_typical_building_from_model method
Add HVAC zone mapping to create typical
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request overview
This pull request updates the create_typical_building measure to include a new optional field that reads in a
Hash
that defines a mapping of CBECS HVAC Type enumerations system types to zones. Enumerations for CBVECS HVAC types can be found hereStructure for this hash is:
Pull Request Author
bundle exec rake doc
)bundle exec rake rubocop
)Review Checklist
This will not be exhaustively relevant to every PR.