Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HVAC zone mapping to create typical #1693

Merged
merged 13 commits into from
Apr 2, 2024

Conversation

jugonzal07
Copy link
Collaborator

@jugonzal07 jugonzal07 commented Feb 23, 2024

Pull request overview

This pull request updates the create_typical_building measure to include a new optional field that reads in a Hash that defines a mapping of CBECS HVAC Type enumerations system types to zones. Enumerations for CBVECS HVAC types can be found here

Structure for this hash is:

['systems'][N]['system_type'] = 'MY_CBECS_HVAC_TYPE'  
['systems'][N]['thermal_zones'] = ['Zone 1', 'Zone 2', ...]

Pull Request Author

  • Method changes or additions
  • Added tests for added methods
  • Documented new methods using yard syntax
  • Resolved yard documentation errors for new code (ran bundle exec rake doc)
  • Resolved rubocop syntax errors for new code (ran bundle exec rake rubocop)
  • All new and existing tests passes

Review Checklist

This will not be exhaustively relevant to every PR.

  • Perform a code review on GitHub
  • All related changes have been implemented: method additions, changes, tests
  • Check rubocop errors
  • Check yard doc errors
  • If a new feature, test the new feature and try creative ways to break it
  • CI status: all green or justified

@lymereJ
Copy link
Collaborator

lymereJ commented Feb 26, 2024

@mdahlhausen - This is work that @jugonzal07 has been doing as part of this OS measure.

Copy link
Collaborator

@mdahlhausen mdahlhausen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for adding this functionality.

I added a sizing run location to the create typical method, updated from master, and made a few rubocop edits.

@mdahlhausen mdahlhausen merged commit 2bd5c78 into master Apr 2, 2024
0 of 2 checks passed
@mdahlhausen mdahlhausen deleted the hvac_zone_mapping_create_typical branch April 2, 2024 15:33
@mdahlhausen mdahlhausen changed the title Hvac zone mapping added for create_typical_building_from_model method Add HVAC zone mapping to create typical Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants