Refactor Sql File methods #1696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- replace thermal_zone_get_unmet_load_hours with thermal_zone_get_annual_occupied_unmet_heating_hours and thermal_zone_get_annual_occupied_unmet_cooling_hours - replace model_annual_energy_by_fuel_and_enduse with model_get_annual_energy_by_fuel_and_enduse - replace model_annual_eui_kbtu_per_ft2 with model_get_annual_eui_kbtu_per_ft2 - replace model_annual_eui_kbtu_per_ft2_by_fuel_and_enduse with model_get_annual_eui_kbtu_per_ft2_by_fuel_and_enduse - replace model_annual_occupied_unmet_cooling_hours with model_get_annual_occupied_unmet_cooling_hours - replace model_annual_occupied_unmet_cooling_hours_detailed with model_get_annual_occupied_unmet_cooling_hours_detailed - replace model_annual_occupied_unmet_heating_hours with model_get_annual_occupied_unmet_heating_hours - replace model_annual_occupied_unmet_heating_hours_detailed with model_get_annual_occupied_unmet_heating_hours_detailed - replace model_annual_occupied_unmet_hours with model_get_annual_occupied_unmet_hours - replace model_dd_energy_by_fuel_by_enduse with model_get_dd_energy_by_fuel_and_enduse - replace model_dd_results_by_end_use_and_fuel_type with model_get_dd_results_by_end_use_and_fuel_type - replace model_results_by_end_use_and_fuel_type with model_get_annual_results_by_end_use_and_fuel_type - replace run_query_tabulardatawithstrings with model_tabular_data_query
|
The fuel types may break with the OS 3.7 update - look at both CIs (3.6.1 and dev) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request overview
Move the SQL access methods into an SqlFile module
Pull Request Author
bundle exec rake doc)bundle exec rake rubocop)Review Checklist
This will not be exhaustively relevant to every PR.