Appendix g merge master 0306 #1705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…penstudio-standards into refactor/schedules_module
…into refactor/parametric_schedules
- add tests for new methods - switch tests to ASHRAESecondarySchool - change space_get_exterior_wall_and_subsurface_area and space_get_exterior_wall_and_subsurface_and_roof_area default to false - use Standard.build for now to access space_plenum? and space_conditioning_category methods - change naming of Foundation F constructions; this will cause regression failures. regenerate names once it's determined that the F construction name changes are the only changes in the model
spaces_get_occupancy_scheudule initial move
- deleted btap/geometry method assign_spaces_to_thermal_zone because it is unused - deleted btap/geometry method enumerate_model because it is unused - deleted btap/geometry method create_thermal_zone because it is unused - btap/geometry method getStoryAboveGround-> model_get_building_stories_above_ground - btap/geometry method getStoryBelowGround -> model_get_building_stories_below_ground - btap/geometry method get_zones_from_storey -> building_story_get_thermal_zones - btap/geometry method getStoryForNominalZCoordinate -> model_get_building_story_for_nominal_height - model_get_story_for_nominal_z_coordinate -> model_get_building_story_for_nominal_height - building_story_get_minimum_z_value -> building_story_get_minimum_height - added tests
changed f-factor names
getBuildingStorys[0] returns the stories in a different order depending on operating system; fix it to Building Story 1 model_get_perimeter_length -> model_get_perimeter
- remove surfaces_lower_z_values, because this method lowers all vertices to target z value, which collapses vertical surfaces to lines. Need a different implementation. Only used in one AEDG measure for partitions. - move model_set_building_north_axis - move model_assign_spaces_to_building_stories - delete model_assign_building_story - create group.rb for three methods: - model_group_zones_by_building_type -> model_group_thermal_zones_by_building_type - model_group_zones_by_type -> model_group_thermal_zones_by_occupancy_type - model_group_zones_by_story -> model_group_thermal_zones_by_building_story
model_num_stories_spanned -> thermal_zones_get_number_of_stories_spanned
- surface_get_door_ratio -> surface_get_window_to_wall_ratio - surface_get_wwr -> surface_get_door_to_wall_ratio - surface_absolute_azimuth -> surface_get_absolute_azimuth - surface_cardinal_direction -> surface_get_cardinal_direction - delete model_get_window_area_info_for_orientation; use model_get_exterior_window_to_wall_ratio instead - delete model_get_window_area_info_for_orientation; use model_get_exterior_window_and_wall_area_by_orientation instead
Refactor geometry module
add new DistrictHeatingWater and DistrictHeatingSteam fuel type columns, copying values from DistrictHeating
…into refactor/parametric_schedules
…EL/openstudio-standards into refactor/parametric_schedules
Move and test parametric schedule methods
Address test failures on master
|
CI shows everything passed but result is still failed: Progress :: |�[32mPASSED: test_LargeOffice-90.1-2016-ASHRAE_169-2013-2A IN FILE test/doe_prototype/test_large_office.rb�[0m Rerun to make sure things are fine. |
…into AppendixG_merge_master_0306
Update regression and performance test results for prototypes
…into AppendixG_merge_master_0306
|
NECBs are failing but that is expected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request overview
Merge geo module refactor into Appx G dev
Pull Request Author
bundle exec rake doc)bundle exec rake rubocop)requirestatements, ensure these are in core ruby or add to the gemspecReview Checklist
This will not be exhaustively relevant to every PR.