Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix backward slash issue in user .csv lookup #1707

Merged
merged 1 commit into from
Mar 11, 2024

Conversation

weilixu
Copy link
Collaborator

@weilixu weilixu commented Mar 8, 2024

Pull request overview

A bug that makes Windows file path format not be able importing user data.

  • Fixes #ISSUENUMBERHERE (IF THIS IS A DEFECT)

Pull Request Author

  • Method changes or additions
  • Data changes or additions
  • Added tests for added methods
  • If methods have been deprecated, update rest of code to use the new methods
  • Documented new methods using yard syntax
  • Resolved yard documentation errors for new code (ran bundle exec rake doc)
  • Resolved rubocop syntax errors for new code (ran bundle exec rake rubocop)
  • All new and existing tests passes
  • If the code adds new require statements, ensure these are in core ruby or add to the gemspec

Review Checklist

This will not be exhaustively relevant to every PR.

  • Perform a code review on GitHub
  • All related changes have been implemented: method additions, changes, tests
  • Check rubocop errors
  • Check yard doc errors
  • If fixing a defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If a new feature, test the new feature and try creative ways to break it
  • CI status: all green or justified

@weilixu weilixu requested a review from lymereJ March 8, 2024 23:41
@weilixu weilixu marked this pull request as ready for review March 11, 2024 17:19
@weilixu weilixu merged commit 10cda1b into AppendixG_Dev Mar 11, 2024
1 of 2 checks passed
@mdahlhausen mdahlhausen changed the title fix the backward slash issue Fix backward slash issue in user .csv lookup Apr 9, 2024
@mdahlhausen mdahlhausen deleted the hotfix_dir_glob_takes_only_backward_slash branch September 3, 2024 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants