Refactor parametric schedules

[eringold]

Pull request overview

Refactors methods to better align model schedules with generated building hours of operation schedule and user inputs to OpenstudioStandards::Schedules.schedule_ruleset_set_hours_of_operation

• Fixes Parametric schedules can result in odd profiles #1551, particularly that thermostat schedules aren't modified

Pull Request Author

• Method changes or additions
• Data changes or additions
• Added tests for added methods
• If methods have been deprecated, update rest of code to use the new methods
• Documented new methods using yard syntax
• Resolved yard documentation errors for new code (ran bundle exec rake doc)
• Resolved rubocop syntax errors for new code (ran bundle exec rake rubocop)
• All new and existing tests passes
• If the code adds new require statements, ensure these are in core ruby or add to the gemspec

Review Checklist

This will not be exhaustively relevant to every PR.

• Perform a code review on GitHub
• All related changes have been implemented: method additions, changes, tests
• Check rubocop errors
• Check yard doc errors
• If fixing a defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
• If a new feature, test the new feature and try creative ways to break it
• CI status: all green or justified

[mdahlhausen]

• Add unit tests to test_schedules_information.rb for these methods:
  • schedule_ruleset_get_annual_days_used
  • schedule_ruleset_get_schedule_day_rule_indices
• Add unit tests to test_schedules_modify.rb for these methods:
  • schedule_day_populate_from_array_of_values
  • schedule_ruleset_create_rules_from_day_list
• These methods in schedules/parametric.rb need parameter descriptions for the yard documentation:
  • gather_inputs_parametric_space_space_type_schedules
  • gather_inputs_parametric_schedules

[eringold]

@mdahlhausen all requested changes have been made.