Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing NECB qaqc reporting #1732

Merged
merged 3 commits into from
Apr 17, 2024
Merged

Fixing NECB qaqc reporting #1732

merged 3 commits into from
Apr 17, 2024

Conversation

ckirney
Copy link
Collaborator

@ckirney ckirney commented Apr 16, 2024

Pull request overview

Include fixes to necb_qaqc.rb to ensure Construction objects are used as such. Include a new test to ensure the NECB qaqc report is correctly generated.

  • Fixes #ISSUENUMBERHERE (IF THIS IS A DEFECT)

Pull Request Author

  • Method changes or additions
  • Data changes or additions
  • Added tests for added methods
  • If methods have been deprecated, update rest of code to use the new methods
  • Documented new methods using yard syntax
  • Resolved yard documentation errors for new code (ran bundle exec rake doc)
  • Resolved rubocop syntax errors for new code (ran bundle exec rake rubocop)
  • All new and existing tests passes
  • If the code adds new require statements, ensure these are in core ruby or add to the gemspec

Review Checklist

This will not be exhaustively relevant to every PR.

  • Perform a code review on GitHub
  • All related changes have been implemented: method additions, changes, tests
  • Check rubocop errors
  • Check yard doc errors
  • If fixing a defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If a new feature, test the new feature and try creative ways to break it
  • CI status: all green or justified

ckirney added 3 commits April 15, 2024 11:46
…ction objects. Updating qaqc_report_expected_result.json to match new results.
… test_necb_qaqc_reporting.rb output. The openstudio-standards revision number changes with every commit causing the test to always fail.
@mdahlhausen mdahlhausen merged commit 286bd3b into master Apr 17, 2024
1 of 2 checks passed
@mdahlhausen mdahlhausen deleted the necb_qaqc_issue branch April 17, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants