Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deer lookup for simple glazing #1743

Merged
merged 1 commit into from
May 15, 2024

Conversation

mdahlhausen
Copy link
Collaborator

@mdahlhausen mdahlhausen commented May 14, 2024

add a valid lookup for deer simple glazing constructions include properties in name for name parsing

Pull request overview

Fixes an issue with DEER templates in create typical

Pull Request Author

  • Data changes or additions
  • Added tests for added methods
  • Resolved yard documentation errors for new code (ran bundle exec rake doc)
  • Resolved rubocop syntax errors for new code (ran bundle exec rake rubocop)
  • All new and existing tests passes

Review Checklist

This will not be exhaustively relevant to every PR.

  • Perform a code review on GitHub
  • All related changes have been implemented: method additions, changes, tests
  • Check rubocop errors
  • Check yard doc errors
  • If fixing a defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • CI status: all green or justified

add a valid lookup for deer simple glazing constructions
include properties in name for name parsing
@mdahlhausen mdahlhausen merged commit 645b555 into master May 15, 2024
1 of 2 checks passed
@mdahlhausen mdahlhausen deleted the fix/deer_simple_glazing_lookup branch May 15, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant