Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow multiple radiant slab boundary conditions #1744

Merged
merged 1 commit into from
May 17, 2024

Conversation

mdahlhausen
Copy link
Collaborator

@mdahlhausen mdahlhausen commented May 15, 2024

The radiant slab construction was only checking for 'Ground' and 'Outdoors' conditions, and treating everything else and interior. Then it would try to find an adjacent surface. That did not exist for models with the 'GroundFCfactorMethod' boundary condition. Adjust to allow multiple radiant slab ground boundary conditions, and check if an adjacent surface exists before getting it.

Pull request overview

Pull Request Author

  • Method changes or additions
  • Resolved yard documentation errors for new code (ran bundle exec rake doc)
  • Resolved rubocop syntax errors for new code (ran bundle exec rake rubocop)
  • All new and existing tests passes

Review Checklist

This will not be exhaustively relevant to every PR.

  • Perform a code review on GitHub
  • All related changes have been implemented: method additions, changes, tests
  • Check rubocop errors
  • Check yard doc errors
  • If fixing a defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • CI status: all green or justified

The radiant slab construction was only checking for 'Ground' and 'Outdoors' conditions, and treating everything else and interior. Then it would try to find an adjacent surface. That did not exist for models with the 'GroundFCfactorMethod' boundary condition. Adjust to allow multiple radiant slab ground boundary conditions, and check if an adjacent surface exists before getting it.
@mdahlhausen mdahlhausen merged commit abc15f6 into master May 17, 2024
1 of 3 checks passed
@mdahlhausen mdahlhausen deleted the fix/radiant_slab_ground_bc branch May 17, 2024 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant