Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NIST infiltration method #1759

Merged
merged 2 commits into from
Jun 13, 2024
Merged

Add NIST infiltration method #1759

merged 2 commits into from
Jun 13, 2024

Conversation

mdahlhausen
Copy link
Collaborator

@mdahlhausen mdahlhausen commented Jun 11, 2024

Pull request overview

  • add method to add NIST infiltration correlations to a model
  • add supporting methods for NIST building type
  • add methods to invert schedules
  • add method to get the HVAC schedule from the model
  • add tests for all the above

Pull Request Author

  • Method changes or additions
  • Data changes or additions
  • Added tests for added methods
  • Documented new methods using yard syntax
  • Resolved yard documentation errors for new code (ran bundle exec rake doc)
  • Resolved rubocop syntax errors for new code (ran bundle exec rake rubocop)
  • All new and existing tests passes

Review Checklist

This will not be exhaustively relevant to every PR.

  • Perform a code review on GitHub
  • All related changes have been implemented: method additions, changes, tests
  • Check rubocop errors
  • Check yard doc errors
  • If fixing a defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If a new feature, test the new feature and try creative ways to break it
  • CI status: all green or justified

- add method to add NIST infiltration correlations to a model
- add supporting methods for NIST building type
- add methods to invert schedules
- add method to get the HVAC schedule from the model
- add tests for all the above
@mdahlhausen
Copy link
Collaborator Author

Three thoughts:

  • It may be better to have a method that returns the HVAC schedule for a subset of zones, not the full model. Though that is easy to add later
  • The method that adds infiltration probably should be separated from the method that sets the infiltration schedules. The reason being is that we'll want to add infiltration values in the off conditions for design sizing for HVAC systems, and then later adjust the infiltration on/off schedules to account for HVAC system operation.
  • We don't have a way to account for the cycling nature of HVAC systems and moving between on/off infiltration regimes

@mdahlhausen mdahlhausen merged commit 7cadf61 into master Jun 13, 2024
1 of 2 checks passed
@mdahlhausen mdahlhausen deleted the module/nist_infiltration branch June 13, 2024 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants