Add dedicated secondary loop for 90.1 PRM plant loops

[jugonzal07]

Pull request overview

This pull implements dedicated secondary loops for the ASHRAE 90.1 PRM plant loops that utilize constant primary, variable secondary configurations. This required updating the hardcoded value that skipped all the secondary loop logic, correctly implementing staging using EMS for the inlet pumps to each chiller, and updating the operation scheme to match the new logic. Allows for adding up to 3 chillers with logic in place to catch scenarios when more than 3 are added to a loop to consolidate them.

Pull Request Author

• Method changes or additions
• Added tests for added methods
• Documented new methods using yard syntax
• Resolved yard documentation errors for new code (ran bundle exec rake doc)
• Resolved rubocop syntax errors for new code (ran bundle exec rake rubocop)
• All new and existing tests passes

Review Checklist

This will not be exhaustively relevant to every PR.

• Perform a code review on GitHub
• All related changes have been implemented: method additions, changes, tests
• Check rubocop errors
• Check yard doc errors
• If fixing a defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
• If a new feature, test the new feature and try creative ways to break it
• CI status: all green or justified

[lymereJ]

Thanks for that! I think that it overall looks good. I'm leaving a few comments/questions below. Also, I think that it would be nice to include a PRM test to make sure that the correct modeling inputs are added. It would be nice to also somehow have a test to check that the pumps/chillers are correctly staged but this might a bit out of scope for now.

[weilixu]

@mdahlhausen This PR is completed and passed the CI. Could you do a review for its merge? Once approved, we will resolve the conflict.

[jugonzal07]

@mdahlhausen -- I went ahead and fixed the merge conflicts, they were related to rubocop fixes as far as I could tell and not in any way relevant to the PR updates.

[mdahlhausen]

@jugonzal07 Looks good to me. Perhaps worth going through and making sure all the conversations are resolved. There is one on renaming the pump name for example that looks unaddressed.

Merge at will.