Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check for stat file missing typical week #1766

Merged
merged 1 commit into from
Jun 19, 2024
Merged

Conversation

mdahlhausen
Copy link
Collaborator

@mdahlhausen mdahlhausen commented Jun 18, 2024

Pull request overview

The ComStock 2018 weather files have incomplete .stat files.
This checks that the typical week content is available before trying to access the data.
Without it causes a failure in methods using ComStock weather files.

Pull Request Author

  • Method changes or additions
  • Added tests for added methods
  • Resolved yard documentation errors for new code (ran bundle exec rake doc)
  • Resolved rubocop syntax errors for new code (ran bundle exec rake rubocop)
  • All new and existing tests passes

Review Checklist

This will not be exhaustively relevant to every PR.

  • Perform a code review on GitHub
  • All related changes have been implemented: method additions, changes, tests
  • Check rubocop errors
  • Check yard doc errors
  • If fixing a defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If a new feature, test the new feature and try creative ways to break it
  • CI status: all green or justified

also add test
this is causing a failure in ComStock using the 0.6.1 os stds release
@mdahlhausen mdahlhausen requested a review from asparke2 June 18, 2024 22:42
@mdahlhausen mdahlhausen merged commit 4953b7b into master Jun 19, 2024
1 of 2 checks passed
@mdahlhausen mdahlhausen deleted the weather_stat_file branch June 19, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant