Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add laboratory elevator properties and schedules #1787

Merged
merged 2 commits into from
Aug 8, 2024
Merged

Add laboratory elevator properties and schedules #1787

merged 2 commits into from
Aug 8, 2024

Conversation

mdahlhausen
Copy link
Collaborator

@mdahlhausen mdahlhausen commented Aug 7, 2024 •
edited
Loading

Pull request overview

Add elevator properties and schedules to the laboratory prototype

Pull Request Author

  • Data changes or additions
  • Added tests for added methods
  • All new and existing tests passes

Review Checklist

  • Perform a code review on GitHub
  • All related changes have been implemented: method additions, changes, tests
  • If fixing a defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If a new feature, test the new feature and try creative ways to break it
  • CI status: all green or justified

@mdahlhausen mdahlhausen merged commit 1aaa2d0 into master Aug 8, 2024
@mdahlhausen mdahlhausen deleted the fix/issue1786 branch August 8, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavidGoldwasser DavidGoldwasser Awaiting requested review from DavidGoldwasser

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issue running create_typical with Laboratory building type
1 participant
@mdahlhausen