Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix logic error in Standards.ZoneHVACComponent.rb #1789

Merged
merged 2 commits into from
Aug 8, 2024
Merged

Conversation

mdahlhausen
Copy link
Collaborator

@mdahlhausen mdahlhausen commented Aug 7, 2024

Pull request overview

Change

    # Standby mode occupancy control
    return true unless zone_hvac_component.thermalZone.empty?

    thermal_zone = zone_hvac_component.thermalZone.get

to

    # Standby mode occupancy control
    return true if zone_hvac_component.thermalZone.empty?

    thermal_zone = zone_hvac_component.thermalZone.get

To resolve error when the zone is empty and .get is called.

Pull Request Author

  • Method changes or additions
  • All new and existing tests passes

Review Checklist

  • Perform a code review on GitHub
  • All related changes have been implemented: method additions, changes, tests
  • If fixing a defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • CI status: all green or justified

@mdahlhausen mdahlhausen merged commit 8172d17 into master Aug 8, 2024
@mdahlhausen mdahlhausen deleted the fix/issue1753 branch August 8, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Logic error in zone_hvac_component_apply_standard_controls
1 participant