Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Building Energy Standards Envelope Requirements Data Update #1795

Merged
merged 43 commits into from
Oct 7, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
43 commits
Select commit Hold shift + click to select a range
df9b151
data_update (construction_propeties_only) 0546f80
leijerry888 Aug 21, 2024
2566528
Fix synthax issues introduced by #1794.
lymereJ Aug 21, 2024
3582854
Merge branch 'fix_synthax' into data_update_0546f80
lymereJ Aug 21, 2024
260404f
Revert ruby3 Rubocop changes.
lymereJ Aug 22, 2024
5fa9355
Update constructions.
lymereJ Aug 23, 2024
a5c4e61
Revert unwanted changes.
lymereJ Aug 23, 2024
df64699
Update constructions and construction sets.
lymereJ Aug 27, 2024
3294a1b
Update other construction sets and constructions files.
lymereJ Aug 27, 2024
d2651cb
Merge branch 'master' into data_update_0546f80
mdahlhausen Aug 30, 2024
05257bb
Misc updates.
lymereJ Aug 30, 2024
978c530
Merge branch 'data_update_0546f80' of https://github.com/NREL/openstu…
lymereJ Aug 30, 2024
023260c
Merge branch 'master' into data_update_0546f80
lymereJ Sep 2, 2024
6b15869
Fix inconsistencies.
lymereJ Sep 3, 2024
510e07b
Merge branch 'data_update_0546f80' of https://github.com/NREL/openstu…
lymereJ Sep 3, 2024
9dc5170
Merge branch 'master' into data_update_0546f80
lymereJ Sep 3, 2024
f27d267
Renaming constructions.
lymereJ Sep 6, 2024
42e6938
Sync with new data.
lymereJ Sep 6, 2024
c9c8ebb
Merge branch 'data_update_0546f80' of https://github.com/NREL/openstu…
lymereJ Sep 6, 2024
d265539
Merge branch 'master' into data_update_0546f80
lymereJ Sep 6, 2024
a5b147f
Decimal place.
lymereJ Sep 6, 2024
9c3442f
Merge branch 'data_update_0546f80' of https://github.com/NREL/openstu…
lymereJ Sep 6, 2024
3663f70
Missing decimal places for VT.
lymereJ Sep 9, 2024
fdc2566
Update expected PRM value.
lymereJ Sep 10, 2024
f231530
Merge branch 'master' into data_update_0546f80
lymereJ Sep 10, 2024
fec57fb
Merge branch 'master' into data_update_0546f80
lymereJ Sep 11, 2024
7b45970
ignore 'Any' ashrae_90_1_prm .jsons in update
mdahlhausen Sep 11, 2024
2210d2d
move climate zone 0 first
mdahlhausen Sep 13, 2024
99a7273
update doe ref window construction lookups
mdahlhausen Sep 13, 2024
6c1e28a
update deer constructions and materials
mdahlhausen Sep 13, 2024
622fae4
rename extraneous simple glazing constructions
mdahlhausen Sep 13, 2024
6683400
Merge branch 'master' into data_update_0546f80
mdahlhausen Sep 18, 2024
41ebe58
update regression models
mdahlhausen Sep 18, 2024
5a99775
Address naming inconsistency in 2013/2016 version of 90.1.
lymereJ Sep 24, 2024
b9f8f21
Update construction sets for 90.1-2013/2016.
lymereJ Sep 25, 2024
ef46ce3
Set stds_type value for windows based on template.
lymereJ Sep 27, 2024
509d553
Merge branch 'master' into data_update_0546f80
lymereJ Sep 30, 2024
2533a28
Merge branch 'master' into data_update_0546f80
lymereJ Oct 2, 2024
529e6b9
Merge branch 'data_update_0546f80' of https://github.com/NREL/openstu…
lymereJ Oct 3, 2024
85bc106
Update performance and regression test results.
lymereJ Oct 3, 2024
187a34d
Create test_performance_expected_dd_results.csv
mdahlhausen Oct 4, 2024
0b610ab
Merge branch 'master' into data_update_0546f80
lymereJ Oct 4, 2024
07e891f
Update performance tests.
lymereJ Oct 7, 2024
c2c8d90
Merge branch 'master' into data_update_0546f80
lymereJ Oct 7, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions data/standards/manage_OpenStudio_Standards.rb
Original file line number Diff line number Diff line change
Expand Up @@ -344,8 +344,8 @@ def export_spreadsheet_to_json(spreadsheet_titles, dataset_type: 'os_stds')
dirs.each { |d| d == 'ALL' ? new_dirs << '*' : new_dirs << "*#{d}*" }
glob_string = "#{standards_dir}/#{new_dirs.join('/')}"
puts "--spreadsheet title embedded search criteria: #{glob_string} yields:"
# template_dirs = Dir.glob(glob_string).select { |f| File.directory?(f) && !f.include?('data') && !f.include?('prm')}
template_dirs = Dir.glob(glob_string).select { |f| File.directory?(f) && !f.include?('data')}
template_dirs = Dir.glob(glob_string).select { |f| File.directory?(f) && !f.include?('data') && !f.include?('ashrae_90_1_prm') }
# template_dirs = Dir.glob(glob_string).select { |f| File.directory?(f) && !f.include?('data') }
template_dirs.each do |template_dir|
puts "----#{template_dir}"
end
Expand Down
2,114 changes: 2,017 additions & 97 deletions data/standards/test_performance_expected_dd_results.csv

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion lib/openstudio-standards/schedules/parametric.rb
Original file line number Diff line number Diff line change
Expand Up @@ -1056,7 +1056,7 @@ def self.schedule_ruleset_apply_parametric_inputs(schedule_ruleset, ramp_frequen
remainder = days_to_fill - value[:days_used]
day_for_rule = days_to_fill - remainder
if remainder.size < days_to_fill.size
autogen_rules[profile_index] = { days_to_fill: day_for_rule, hoo_start: hoo_start, hoo_end: hoo_end}
autogen_rules[profile_index] = { days_to_fill: day_for_rule, hoo_start: hoo_start, hoo_end: hoo_end }
end
days_to_fill = remainder
end
Expand Down
12 changes: 10 additions & 2 deletions lib/openstudio-standards/standards/Standards.PlanarSurface.rb
Original file line number Diff line number Diff line change
Expand Up @@ -94,9 +94,17 @@ def planar_surface_apply_standard_construction(planar_surface, climate_zone, pre
end
case stds_type
when 'Metal Framing', 'Metal Framing with Thermal Break'
stds_type = 'Metal framing (all other)'
if template == '90.1-2013'
stds_type = 'Metal framing, fixed'
else
stds_type = 'Metal framing (all other)'
end
when 'Non-Metal Framing'
stds_type = 'Nonmetal framing (all)'
if template == '90.1-2013'
stds_type = 'Nonmetal framing, all'
else
stds_type = 'Nonmetal framing (all)'
end
when 'Any Vertical Glazing'
stds_type = 'Any Vertical Glazing'
else
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ def model_get_percent_of_surface_range(model, wwr_parameter)
if intended_surface_type == 'ExteriorWindow' || intended_surface_type == 'GlassDoor'
wwr = OpenstudioStandards::Geometry.model_get_exterior_window_to_wall_ratio(model)
if wwr <= 0.1
wwr_range['minimum_percent_of_surface'] = 1.0
wwr_range['minimum_percent_of_surface'] = 0.0
wwr_range['maximum_percent_of_surface'] = 10.0
elsif wwr <= 0.2
wwr_range['minimum_percent_of_surface'] = 10.001
Expand All @@ -27,7 +27,7 @@ def model_get_percent_of_surface_range(model, wwr_parameter)
wwr_range['maximum_percent_of_surface'] = 40
else
wwr_range['minimum_percent_of_surface'] = 40.001
wwr_range['maximum_percent_of_surface'] = 100.0
wwr_range['maximum_percent_of_surface'] = 50.0
end
end
return wwr_range
Expand Down
Loading