Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update from nrcan branch #1850

Merged
merged 22 commits into from
Nov 13, 2024
Merged

Update from nrcan branch #1850

merged 22 commits into from
Nov 13, 2024

Conversation

ckirney
Copy link
Collaborator

@ckirney ckirney commented Nov 13, 2024

Pull request overview

  • Fixes #ISSUENUMBERHERE (IF THIS IS A DEFECT)

Pull Request Author

  • Method changes or additions
  • Data changes or additions
  • Added tests for added methods
  • If methods have been deprecated, update rest of code to use the new methods
  • Documented new methods using yard syntax
  • Resolved yard documentation errors for new code (ran bundle exec rake doc)
  • Resolved rubocop syntax errors for new code (ran bundle exec rake rubocop)
  • All new and existing tests passes
  • If the code adds new require statements, ensure these are in core ruby or add to the gemspec

Review Checklist

This will not be exhaustively relevant to every PR.

  • Perform a code review on GitHub
  • All related changes have been implemented: method additions, changes, tests
  • Check rubocop errors
  • Check yard doc errors
  • If fixing a defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If a new feature, test the new feature and try creative ways to break it
  • CI status: all green or justified

khaddad and others added 22 commits August 15, 2024 12:01
… and set non-HP boiler capacity ratios (if using more than one non-HP boiler).
…o, adding back support for the 'defaultfuel' fuel type.
Update DevContainer configuration and add virtual environment to .git…
…xtensions, SQLite viewer, and setting environment language
Enhance DevContainer configuration by adding Python and CSV editing e…
…allation and adjust virtual environment setup
test and qaqc reporting test to accomodate changes
to json output.
Including ability to control backup boilers for GSHP ECM and some fixes
@ckirney ckirney merged commit cde8482 into nrcan_oee_dev Nov 13, 2024
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants