Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update code to determine if HW loop is required for a Heating system. Removing support for TPFC systems for cooling only until code supports it. #1867

Merged
merged 7 commits into from
Dec 18, 2024
Merged

Update code to determine if HW loop is required for a Heating system. Removing support for TPFC systems for cooling only until code supports it. #1867

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
b80a994
Merge pull request #1858 from NREL/nrcan_434
ckirney Dec 9, 2024
e5e8216
Including some minor fixes and significant revisions to code checking
ckirney Dec 10, 2024
3438fcc
Merge pull request #1862 from NREL/nrcan_434_sg
ckirney Dec 10, 2024
345d8ec
Inculding more changes to support code which determines if a hot water
ckirney Dec 11, 2024
ff837bf
Merge pull request #1863 from NREL/nrcan_434
ckirney Dec 11, 2024
e1e22ae
Including code to adjust system fuel types
ckirney Dec 13, 2024
acb5859
Removing HVAC system 5 which appears to be cooling only. Keeping the…
ckirney Dec 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions lib/openstudio-standards/standards/necb/ECMS/hvac_systems.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -819,9 +819,9 @@ def add_air_system(model:,
sys_name_pars['sys_rf'] = 'none'
sys_name_pars['sys_rf'] = 'cv' if sys_ret_fan_type == 'constant_volume'
sys_name_pars['sys_rf'] = 'vv' if sys_ret_fan_type == 'variable_volume'
assign_base_sys_name( air_loop: airloop,
sys_abbr: sys_abbr,
sys_oa: sys_vent_type,
assign_base_sys_name( air_loop: airloop,
sys_abbr: sys_abbr,
sys_oa: sys_vent_type,
sys_name_pars: sys_name_pars)
return airloop, clg_eqpt, htg_eqpt, return_fan
end
Expand Down Expand Up @@ -3536,11 +3536,11 @@ def add_ecm_remove_airloops_add_zone_baseboards(model:,

# Create the hot water loop if necessary.
hw_loop = standard.create_hw_loop_if_required(
baseboard_type,
boiler_fueltype,
backup_boiler_fueltype,
mau_heating_coil_type,
model
baseboard_type: baseboard_type,
boiler_fueltype: boilder_fueltype,
backup_boiler_fueltype: backup_boiler_fueltype,
mau_heating_coil_type: mau_heating_coil_type,
model: model
)

# Add baseboard heaters to each heated zone.
Expand Down
Loading