Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Including nrcan branch changes into nrcan_446 #1874

Merged
merged 6 commits into from
Jan 14, 2025
Merged

Including nrcan branch changes into nrcan_446 #1874

merged 6 commits into from
Jan 14, 2025

Conversation

ckirney
Copy link
Collaborator

@ckirney ckirney commented Jan 14, 2025

Pull request overview

  • Fixes #ISSUENUMBERHERE (IF THIS IS A DEFECT)

Pull Request Author

  • Method changes or additions
  • Data changes or additions
  • Added tests for added methods
  • If methods have been deprecated, update rest of code to use the new methods
  • Documented new methods using yard syntax
  • Resolved yard documentation errors for new code (ran bundle exec rake doc)
  • Resolved rubocop syntax errors for new code (ran bundle exec rake rubocop)
  • All new and existing tests passes
  • If the code adds new require statements, ensure these are in core ruby or add to the gemspec

Review Checklist

This will not be exhaustively relevant to every PR.

  • Perform a code review on GitHub
  • All related changes have been implemented: method additions, changes, tests
  • Check rubocop errors
  • Check yard doc errors
  • If fixing a defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If a new feature, test the new feature and try creative ways to break it
  • CI status: all green or justified

srgilani and others added 6 commits December 10, 2024 16:18
…mestep output (In progress); Reformated output_hourly_data method in btap_datapoint.rb to make it more readable
…puts in csv with timesteps as first column rather than first row
…puts in csv with timesteps as a column instead of having timesteps in the first row like the hourly output, and corrected number of total timesteps in the whole year to have the right number of rows in the generated csv file
nrcan_447: Add capability to extract timestep outputs
@ckirney ckirney merged commit e60c1e1 into nrcan_446 Jan 14, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants