Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates to work with SAM pull request 1325 and ssc pull request 969 #146

Merged
merged 7 commits into from
Apr 27, 2023
Merged

Updates to work with SAM pull request 1325 and ssc pull request 969 #146

merged 7 commits into from
Apr 27, 2023

Conversation

sjanzou
Copy link
Collaborator

@sjanzou sjanzou commented Apr 24, 2023

Updates for pysam to work with flattened SAM UI variables (e.g. Adjustment Factors)

@sjanzou sjanzou self-assigned this Apr 24, 2023
@sjanzou sjanzou requested review from brtietz and dguittet April 24, 2023 11:09
dguittet
dguittet approved these changes Apr 25, 2023
View reviewed changes
Copy link
Collaborator

@dguittet dguittet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just some minor changes then I think it's good to merge

build_manylinux_arm64.sh Outdated Show resolved Hide resolved
build_conda_arm64.sh Outdated Show resolved Hide resolved
@sjanzou sjanzou merged commit 046c47b into dev Apr 27, 2023
@sjanzou sjanzou deleted the adjsutment_factors_update branch April 27, 2023 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dguittet dguittet dguittet approved these changes

@brtietz brtietz Awaiting requested review from brtietz

Assignees

@sjanzou sjanzou

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sjanzou @dguittet