Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change filt variable from global to local #399

Merged
merged 4 commits into from
Nov 17, 2023
Merged

change filt variable from global to local #399

merged 4 commits into from
Nov 17, 2023

Conversation

martin-springer
Copy link
Collaborator

@martin-springer martin-springer commented Nov 16, 2023 •
edited by mdeceglie
Loading

  • Code changes are covered by tests
  • Code changes have been evaluated for compatibility/integration with TrendAnalysis
  • New functions added to __init__.py
  • API.rst is up to date, along with other sphinx docs pages
  • Example notebooks are rerun and differences in results scrutinized
  • Updated changelog

@martin-springer martin-springer changed the base branch from development to master November 16, 2023 17:37
@martin-springer martin-springer mentioned this pull request Nov 16, 2023
Closed
6 tasks
@mdeceglie mdeceglie changed the title change filt variable from global to local (from master branch for testing) change filt variable from global to local Nov 17, 2023
mdeceglie
mdeceglie approved these changes Nov 17, 2023
View reviewed changes
Copy link
Collaborator

@mdeceglie mdeceglie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @martin-springer!

@mdeceglie mdeceglie merged commit 17970d3 into master Nov 17, 2023
16 checks passed
@mdeceglie mdeceglie deleted the fix_irradiance_rescale_from_master branch November 17, 2023 18:02
@mdeceglie mdeceglie mentioned this pull request Nov 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdeceglie mdeceglie mdeceglie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@martin-springer @mdeceglie