Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.0 Release #448

Open
wants to merge 443 commits into
base: master
Choose a base branch
from
Open

3.0 Release #448

wants to merge 443 commits into from

Conversation

mdeceglie
Copy link
Collaborator

Each of these changes has been individually reviewed in PRs to development. Let's make sure that everything is polished for the 3.0 release.

  • Code changes are covered by tests
  • Code changes have been evaluated for compatibility/integration with TrendAnalysis
  • New functions added to __init__.py
  • API.rst is up to date, along with other sphinx docs pages
  • Example notebooks are rerun and differences in results scrutinized
  • Updated changelog

@codecov-commenter
Copy link

codecov-commenter commented Dec 31, 2024

Codecov Report

Attention: Patch coverage is 93.72624% with 66 lines in your changes missing coverage. Please review.

Project coverage is 96.21%. Comparing base (f64428f) to head (bd86075).

Files with missing lines Patch % Lines
rdtools/soiling.py 90.41% 48 Missing ⚠️
rdtools/analysis_chains.py 94.17% 13 Missing ⚠️
rdtools/plotting.py 90.90% 3 Missing ⚠️
rdtools/degradation.py 94.11% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master     #448       +/-   ##
===========================================
+ Coverage   69.96%   96.21%   +26.25%     
===========================================
  Files          12       12               
  Lines        2111     2274      +163     
===========================================
+ Hits         1477     2188      +711     
+ Misses        634       86      -548     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

docs/sphinx/source/index.rst Outdated Show resolved Hide resolved
rdtools/__init__.py Show resolved Hide resolved
rdtools/analysis_chains.py Outdated Show resolved Hide resolved
"gamma_pdc": self.gamma_pdc}
warnings.warn(
"Temperature coefficient not passed in to TrendAnalysis"
". No temperature correction will be conducted."
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
". No temperature correction will be conducted."
"No temperature correction will be conducted."

rdtools/bootstrap.py Outdated Show resolved Hide resolved
docs/sphinx/source/changelog.rst Show resolved Hide resolved
docs/sphinx/source/changelog/v3.0.0.rst Outdated Show resolved Hide resolved
docs/sphinx/source/changelog/v3.0.0.rst Outdated Show resolved Hide resolved
@martin-springer
Copy link
Collaborator

After merging this PR, I think it would be a good time to rename the default branch to main #406
(https://github.com/github/renaming#rename-existing)

mdeceglie and others added 10 commits January 8, 2025 09:18
Co-authored-by: Martin Springer <97482055+martin-springer@users.noreply.github.com>
Co-authored-by: Martin Springer <97482055+martin-springer@users.noreply.github.com>
Co-authored-by: Martin Springer <97482055+martin-springer@users.noreply.github.com>
Co-authored-by: Martin Springer <97482055+martin-springer@users.noreply.github.com>
Co-authored-by: Martin Springer <97482055+martin-springer@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants