Correctly extract grouped attrs #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cludes grouped ones
bnb32
approved these changes
Aug 15, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Aug 15, 2024
Correctly extract grouped attrs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correctly extract
attrs,chunks,shapes, etc. for datasets belonging to a group.This includes
ResourceandMultiFileResource.This does not include the
RechunkH5class since it was not built for grouped datasets (added this as a note to the docstring) and would require more careful refactoring. This could be a future endeavor.Did not find any other instances of reading datasets using
h5pydirectly inrex, but it's possible I missed some. Can fix those in the same manner if/when they come up.Also marked that BC test that keeps failing as flaky for more flexibility.