Rename Generic System to Custom Generation Profile #1228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duplicate generic data file from test
cpaulgilman
requested changes
Oct 28, 2024
There was a problem hiding this comment.
Generally looks good -- a few requests:
- Change UI form group label from "Generic System" to "Custom Generation" on Custom Generation Plant and Custom Generation Costs forms. Also note "Generic Battery" in group label for Custom Generation Battery Costs form -- should that be "Custom Generation Battery"?
-
Remove "formerly" from configuration tree to make it cleaner and take up less space.
-
Rename "Power Plant Losses" on Custom Generation Profile page to "Losses".
-
Rename group label on Power Plant page from "Custom Generation Profile Power Plant" to "Custom Generation Profile".
-
Rename "Power Plant" in navigation menu to "Generation Profile" for hybrid, generic, and generic-battery configurations.
mjprilliman
requested review from
cpaulgilman
and removed request for
sjanzou
cpaulgilman
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-See NREL/SAM#1890
-Fixes NREL/SAM#1849
-Update generic cmod, rename for custom generation
-Include reference to Generic System name in cmod description for backwards reference
-Update test naming conventions, test files
-replace key word reference to generic system where appropriate
-Leave 'Generic CSP' references as they are