Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the README/docs to add Coulombic efficiency to the model description. It also fixes a "bug" reported in the old ROVI-org repo where
plt.show()
in the solutions class was not set up for blocking when running scripts outside of interactive environments.Fixes Issue #12.
Type of change
Key checklist:
$ nox -s linter [-- format]
$ nox -s codespell [-- write]
$ nox -s tests
$ nox -s badges
Further checks:
$ nox -s docs
.