Adaptation of the profile collection for use with QueueServer - 2 #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmgav
changed the title
dmgav
force-pushed
the
remote_experiments_dama2
branch
from
a3e3553
to
f0583ed
Compare
dmgav
force-pushed
the
remote_experiments_dama2
branch
from
198a0ec
to
6a7e96b
Compare
|
I am troubled that I am asked to accept a PR of this size with one vague sentence of explanation and no real discussion of the context of the changes proposed. |
|
@bruceravel This branch includes code changes that are necessary to load the profile collection in Queue Server environment. We created this branch in November when we were testing the Queue Server the first time. Currently we are preparing for the next series of tests, so I rebased the code to include changes to master branch since November. There are no plans to merge the branch yet. In principle, the startup code from this branch is supposed to run identically to the original code if started from IPython, but it was never tested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is rebased version of
remote_experiments_dama2that includes latest work onxpress3.