Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: 修正 cov 顯示問題、修正部分 #46 #48

Merged
merged 2 commits into from
Dec 12, 2023
Merged

fix: 修正 cov 顯示問題、修正部分 #46 #48

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
54de7f0
fix(smokeshow): fix cov report path
iwtba4188 Dec 12, 2023
f580827
fix(buses): invalid escape sequence in regex (fixed partial #46)
iwtba4188 Dec 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/smokeshow.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ jobs:
with:
workflow: tests.yml
commit: ${{ github.event.workflow_run.head_sha }}
- run: smokeshow upload coverage
- run: smokeshow upload coverage/coverage
env:
SMOKESHOW_GITHUB_STATUS_DESCRIPTION: Coverage {coverage-percentage}
SMOKESHOW_GITHUB_COVERAGE_THRESHOLD: 85
Expand Down
4 changes: 2 additions & 2 deletions src/api/models/buses.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,7 @@ def __init__(self) -> None:
self.detailed_data = {}

def _parse_campus_info(self, variable_string: str):
regex_pattern = r"const " + variable_string + " = (\{.*?\})"
regex_pattern = r"const " + variable_string + r" = (\{.*?\})"
data = re.search(regex_pattern, self._res_text, re.S)
if data is not None:
data = data.group(1)
Expand All @@ -177,7 +177,7 @@ def _parse_campus_info(self, variable_string: str):
return data

def _parse_bus_schedule(self, variable_string: str):
regex_pattern = r"const " + variable_string + " = (\[.*?\])"
regex_pattern = r"const " + variable_string + r" = (\[.*?\])"
data = re.search(regex_pattern, self._res_text, re.S)
if data is not None:
data = data.group(1)
Expand Down