Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: main board required when not present #167

Merged
merged 1 commit into from
Jan 15, 2024
Merged

fix: main board required when not present #167

merged 1 commit into from
Jan 15, 2024

Conversation

LiviaValenti
Copy link
Collaborator

Hotfix 🥔

Summary of changes

  • When main board is not chosen in the form, the field is only visually hidden, thus the required field must be removed.

@LiviaValenti LiviaValenti added bug 🐞 Something isn't working frontend ✨ Frontend tasks critical 📢 Top priority labels Jan 15, 2024
@LiviaValenti LiviaValenti self-assigned this Jan 15, 2024
@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://witty-wave-0f9910103-167.westeurope.2.azurestaticapps.net

Shomlings
Shomlings approved these changes Jan 15, 2024
View reviewed changes
Copy link
Member

@Shomlings Shomlings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@Shomlings Shomlings merged commit 847d121 into master Jan 15, 2024
3 checks passed
@Shomlings Shomlings deleted the fix/form-field-required-bug branch January 15, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shomlings Shomlings Shomlings approved these changes

@edalholt edalholt Awaiting requested review from edalholt

Assignees

@LiviaValenti LiviaValenti

Labels
bug 🐞 Something isn't working critical 📢 Top priority frontend ✨ Frontend tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LiviaValenti @Shomlings