Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: add eslint, prettier and react-router #18

Merged
merged 5 commits into from
Feb 26, 2022

Conversation

Xtrah
Copy link
Member

@Xtrah Xtrah commented Feb 25, 2022

Closes #12

Summary of changes

Add react-router, ESLint and prettier. Prettify everything ✨

Xtrah and others added 3 commits February 25, 2022 17:49
Co-authored-by: LiviaValenti <LiviaValenti@users.noreply.github.com>
Co-authored-by: LiviaValenti <LiviaValenti@users.noreply.github.com>
Co-authored-by: LiviaValenti <LiviaValenti@users.noreply.github.com>
Copy link
Collaborator

@LiviaValenti LiviaValenti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works locally 🚀

Some improvements have to be made regarding prettier, and potentially the run-scripts but after that it LGTM ✔️

package.json Outdated Show resolved Hide resolved
.prettierrc.json Show resolved Hide resolved
Xtrah and others added 2 commits February 26, 2022 12:33
Co-authored-by: LiviaValenti <LiviaValenti@users.noreply.github.com>
@Xtrah Xtrah merged commit 699a10e into master Feb 26, 2022
@Xtrah Xtrah deleted the style/combined-eslint-prettier branch February 26, 2022 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Initial project setup
3 participants