Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: application and committee types #24

Merged
merged 2 commits into from
Mar 2, 2022
Merged

fix: application and committee types #24

merged 2 commits into from
Mar 2, 2022

Conversation

LiviaValenti
Copy link
Collaborator

@LiviaValenti LiviaValenti commented Mar 1, 2022 •
edited
Loading

Related to #15

Summary of changes

  • Fix type error (string to number) on arrays in fixtures
  • Remove unused parameter _id = false as it was overridden
  • Refactor verbose type-definitions
  • Improve specificity of fixtures to avoid misunderstandings

Now querying the data generated by the fixtures should work (relatively) smoothly 🛩️

Thanks to @SanderArntzen for pointing out the messy typing and @Xtrah for the aid in troubleshooting ❤️

@LiviaValenti LiviaValenti added the backend 🍑 Backend tasks label Mar 1, 2022
@LiviaValenti LiviaValenti self-assigned this Mar 1, 2022
@LiviaValenti
refactor: verbose type definitions and parameters
941a7bf 
* removed _id = false as it is unused and overrided
@LiviaValenti LiviaValenti force-pushed the fix/application-committee-types branch from 8db545e to 941a7bf Compare March 1, 2022 22:52
@LiviaValenti LiviaValenti requested a review from Xtrah March 1, 2022 23:01
Xtrah
Xtrah approved these changes Mar 2, 2022
View reviewed changes
Copy link
Member

@Xtrah Xtrah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Types 🥰🙃

@LiviaValenti LiviaValenti linked an issue Mar 2, 2022 that may be closed by this pull request
Create backend for applications #15
Closed
4 tasks
@LiviaValenti LiviaValenti merged commit 35e3648 into dev Mar 2, 2022
@LiviaValenti LiviaValenti deleted the fix/application-committee-types branch March 2, 2022 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xtrah Xtrah Xtrah approved these changes

Assignees

@LiviaValenti LiviaValenti

Labels
backend 🍑 Backend tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create backend for applications
2 participants
@LiviaValenti @Xtrah