Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: get application by id #45

Merged
merged 2 commits into from
Mar 23, 2022
Merged

feat: get application by id #45

merged 2 commits into from
Mar 23, 2022

Conversation

LiviaValenti
Copy link
Collaborator

Closes #37

Summary of changes

  • Endpoint GET against /applications/:application-id to retrieve specific application
  • Return application if logged in user is part of committee that the application is sent to

@LiviaValenti LiviaValenti added the backend 🍑 Backend tasks label Mar 21, 2022
@LiviaValenti LiviaValenti self-assigned this Mar 21, 2022
@LiviaValenti LiviaValenti requested review from Xtrah and HenrikVL March 21, 2022 20:16
@LiviaValenti
feat: get application by id
dae2371 
* endpoint to retrieve application by id
@LiviaValenti LiviaValenti force-pushed the feat/get-application branch from a438b36 to dae2371 Compare March 22, 2022 19:49
Xtrah
Xtrah approved these changes Mar 23, 2022
View reviewed changes
Copy link
Member

@Xtrah Xtrah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SanderArntzen has a good point, other than LGTM 📈

@LiviaValenti LiviaValenti merged commit 40d5bf7 into dev Mar 23, 2022
@LiviaValenti LiviaValenti deleted the feat/get-application branch March 23, 2022 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SanderArntzen SanderArntzen SanderArntzen left review comments

@Xtrah Xtrah Xtrah approved these changes

@HenrikVL HenrikVL Awaiting requested review from HenrikVL

Assignees

@LiviaValenti LiviaValenti

Labels
backend 🍑 Backend tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make backend for access to specific application
3 participants
@LiviaValenti @Xtrah @SanderArntzen