Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: application detail frontend #47

Merged
merged 10 commits into from
Mar 28, 2022
Merged

Conversation

LiviaValenti
Copy link
Collaborator

@LiviaValenti LiviaValenti commented Mar 23, 2022

Closes #38
Closes #7

Summary of changes

  • Page with application details
  • Routing for application items
  • ⚠️ Updated vulnerable package

@LiviaValenti LiviaValenti requested a review from HenrikVL March 23, 2022 11:55
@LiviaValenti LiviaValenti force-pushed the application_detail_frontend branch from f4f163e to 760373f Compare March 23, 2022 14:36
@LiviaValenti LiviaValenti marked this pull request as ready for review March 23, 2022 17:48
@LiviaValenti LiviaValenti added the frontend ✨ Frontend tasks label Mar 23, 2022
@LiviaValenti LiviaValenti requested a review from supapesh March 23, 2022 18:53
Copy link
Contributor

@supapesh supapesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job as always, Livia (thanks for helping me🥰). I've tried it on my local machine and it runs smoothly with the responsive design aswell.

Appended some very small changes in code (but perhaps they shape the product a bit too much). Let me know what you think of them!

frontend/src/pages/ApplicationDetails.tsx Show resolved Hide resolved
frontend/src/pages/ApplicationDetails.tsx Outdated Show resolved Hide resolved
frontend/src/pages/ApplicationDetails.tsx Show resolved Hide resolved
@LiviaValenti LiviaValenti force-pushed the application_detail_frontend branch from 0640e74 to 0c27577 Compare March 26, 2022 16:22
Copy link
Collaborator

@HenrikVL HenrikVL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! I think it looks great! I submitted some feedback that should be addressed, but I think this is good enough to be merged 💃

frontend/src/pages/ApplicationDetails.tsx Outdated Show resolved Hide resolved
frontend/src/pages/ApplicationDetails.tsx Show resolved Hide resolved
frontend/src/pages/ApplicationDetails.tsx Show resolved Hide resolved
frontend/src/pages/ApplicationDetails.tsx Show resolved Hide resolved
frontend/src/pages/ApplicationDetails.tsx Outdated Show resolved Hide resolved
@LiviaValenti LiviaValenti requested a review from HenrikVL March 27, 2022 11:31
@LiviaValenti LiviaValenti force-pushed the application_detail_frontend branch from 11331c7 to bd7943b Compare March 27, 2022 12:43
Copy link
Collaborator

@HenrikVL HenrikVL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Ready to merge!

@LiviaValenti LiviaValenti merged commit 08dd4d4 into dev Mar 28, 2022
@LiviaValenti LiviaValenti deleted the application_detail_frontend branch March 28, 2022 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend ✨ Frontend tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create frontend for detail page Application detail view
3 participants