Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: set admission status for committees frontend #51

Merged
merged 14 commits into from
Mar 28, 2022

Conversation

HenrikVL
Copy link
Collaborator

@HenrikVL HenrikVL commented Mar 24, 2022

Related to #34

Summary of changes

This pull request contains a working admission status manager. It is connected to the backend and changes values in real time. However, there are still some missing features.

Missing features:

  • Access control
  • Display admission time dates

How it looks:

Screenshot 2022-03-24 at 13 38 39

@HenrikVL HenrikVL added the frontend ✨ Frontend tasks label Mar 24, 2022
@HenrikVL HenrikVL added this to the Sprint 2 milestone Mar 24, 2022
@HenrikVL HenrikVL self-assigned this Mar 24, 2022
@Xtrah Xtrah changed the title Feat/open committees feat: set admission status for committees frontend Mar 24, 2022
@HenrikVL HenrikVL marked this pull request as ready for review March 26, 2022 11:35
@HenrikVL
Copy link
Collaborator Author

Hola! 👋

This PR now includes all the features required by the user story (#4) and corresponding issue (#34).

The current build includes:

  • Access control (only shows committees which the user is leader of)
  • A display of the current admission period
  • Real-time toggle of admission

How it looks: 👁👄👁

Screenshot 2022-03-26 at 12 54 45

Error handling is still a bit lacking and should be reviewed further.

Happy reviewing! 🕺

Copy link
Collaborator

@LiviaValenti LiviaValenti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️ Super clean and readable code
✨ It looks good and is super snappy

I have some requests (mostly error-handling). All in all great work 🤩

frontend/src/components/committeeSwitch.tsx Outdated Show resolved Hide resolved
frontend/src/components/committeeSwitch.tsx Outdated Show resolved Hide resolved
frontend/src/components/committeeSwitch.tsx Outdated Show resolved Hide resolved
frontend/src/components/committeeSwitch.tsx Outdated Show resolved Hide resolved
frontend/src/components/committeeSwitch.tsx Outdated Show resolved Hide resolved
frontend/src/pages/AdmissionStatus.tsx Outdated Show resolved Hide resolved
frontend/src/pages/AdmissionStatus.tsx Outdated Show resolved Hide resolved
frontend/src/pages/AdmissionStatus.tsx Outdated Show resolved Hide resolved
frontend/src/services/Committees.ts Outdated Show resolved Hide resolved
frontend/src/services/Committees.ts Outdated Show resolved Hide resolved
frontend/src/pages/AdmissionStatus.tsx Show resolved Hide resolved
frontend/src/pages/AdmissionStatus.tsx Outdated Show resolved Hide resolved
frontend/src/pages/AdmissionStatus.tsx Outdated Show resolved Hide resolved
frontend/src/components/committeeSwitch.tsx Outdated Show resolved Hide resolved
@HenrikVL HenrikVL force-pushed the feat/open-committees branch from bb0d3b4 to dbc3f8b Compare March 27, 2022 17:00
@HenrikVL HenrikVL requested a review from LiviaValenti March 27, 2022 17:47
Copy link
Collaborator

@LiviaValenti LiviaValenti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on fixing what we requested🥇 The error-handling still lacks a bit of refinement.

frontend/src/pages/AdmissionStatus.tsx Outdated Show resolved Hide resolved
frontend/src/pages/AdmissionStatus.tsx Show resolved Hide resolved
frontend/src/pages/AdmissionStatus.tsx Show resolved Hide resolved
@HenrikVL HenrikVL requested a review from LiviaValenti March 28, 2022 08:24
@HenrikVL HenrikVL force-pushed the feat/open-committees branch from 0571383 to ad13367 Compare March 28, 2022 11:00
Copy link
Collaborator

@LiviaValenti LiviaValenti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome job, Henrik 🚀🌕

I have tested it relatively thoroughly, but I am becoming a bit blind to the code at this point 👓 But it LGTM now.

@HenrikVL HenrikVL merged commit 87fed0b into dev Mar 28, 2022
@HenrikVL HenrikVL deleted the feat/open-committees branch March 28, 2022 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend ✨ Frontend tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make frontend page allowing user to open/close applications to their committee
3 participants