-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: set admission status for committees frontend #51
Conversation
Hola! 👋This PR now includes all the features required by the user story (#4) and corresponding issue (#34). The current build includes:
How it looks: 👁👄👁 Error handling is still a bit lacking and should be reviewed further. Happy reviewing! 🕺 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✔️ Super clean and readable code
✨ It looks good and is super snappy
I have some requests (mostly error-handling). All in all great work 🤩
bb0d3b4
to
dbc3f8b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job on fixing what we requested🥇 The error-handling still lacks a bit of refinement.
- If user is organizer --> display all committees
0571383
to
ad13367
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome job, Henrik 🚀🌕
I have tested it relatively thoroughly, but I am becoming a bit blind to the code at this point 👓 But it LGTM now.
Related to #34
Summary of changes
This pull request contains a working admission status manager. It is connected to the backend and changes values in real time. However, there are still some missing features.
Missing features:
How it looks: