feat: only allow applications in application period

[Xtrah]

Closes #43

Summary of changes

• Throw error if applications are posted outside of application period
• Update applicationPeriodStatus check to include the end date in the application period
• Force MongoDB to use applicationperiod as collection instead of defaulting to applicationperiods

[LiviaValenti]

Nice 📈 Will test it locally tomorrow 🧪

[SanderArntzen]

Nice changes, good catch on the end date for period status check.
Can't test it locally before the test-user is authorized again in the dev-environment, so can't approve the PR yet

[SanderArntzen]

The code changes behaves as expected when tested locally. Nice!

[LiviaValenti]

Nice work! I can see we have some issues with error-handling. E.g. when the application period does not exist. I also noticed if you send a bad request (e.g. no body) to the applications-endpoint it crashes the app 👀

Can be partially fixed by adding a proper catch with some responses after .then in postApplication, but its a tiny bit hacky 😕

E.g.

.catch((err) => { if(err.name === 'ValidationError'){ return res.status(400).json({ message: err.message }) } return res.status(500).json({ message: "Unable to save application" }) })

[LiviaValenti]

⭐

[LiviaValenti]

LGTM 🚀 @SanderArntzen, can you test one last time?

[SanderArntzen]

The error-handling for when application period doesn't exist, and sending a uncomplete body to POST application, works now. Good job 👍