Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: authorization in admission-status #63

Merged
merged 3 commits into from
Mar 31, 2022
Merged

fix: authorization in admission-status #63

merged 3 commits into from
Mar 31, 2022

Conversation

LiviaValenti
Copy link
Collaborator

@LiviaValenti LiviaValenti commented Mar 29, 2022 •
edited
Loading

Closes #55

Previously the admission-status toggle did not check if you were the part of the committee or organizer.

Summary of changes

  • checks if requesting user is organizer or baord member of committee
  • add mainboard ID as constant
  • add utility to retrieve roles in committee
  • fix getUserCommittee query (now uses _id in the query)
  • refactored application-status and application-period to admission-period and admission-status

⚠️ Load new fixtures to test ⚠️

@LiviaValenti
fix: authorization in admission
25acc66 
* checks if leader or organizer
* add mainboard ID as const
* add utility to retrieve roles in committee
* fix getUserCommittee query
@LiviaValenti LiviaValenti added the backend 🍑 Backend tasks label Mar 29, 2022
@LiviaValenti LiviaValenti self-assigned this Mar 29, 2022
@LiviaValenti
fix: allow all board members to change access
740bec7 
* removed restriction that only leader can set access
@Xtrah
Copy link
Member

Xtrah commented Mar 30, 2022

❓ Should we refactor application-status to admission-status everywhere?

Yes

@LiviaValenti
refactor: application to admission
13cc76e 
- application period to admission period
- accept applications to accepts admissions
@LiviaValenti
Copy link
Collaborator Author

⚠️ Cannot send applications outside of application-period

Currently we do not display that the application period is over in frontend, thus if the application period is over you will recieve an error. This will be fixed in PR #62

Xtrah
Xtrah approved these changes Mar 31, 2022
View reviewed changes
Copy link
Member

@Xtrah Xtrah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazeballs, everything works as expected 🥇

@LiviaValenti LiviaValenti merged commit 464a93d into dev Mar 31, 2022
@LiviaValenti LiviaValenti deleted the fix/admission-status-authorization branch March 31, 2022 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xtrah Xtrah Xtrah approved these changes

@SanderArntzen SanderArntzen Awaiting requested review from SanderArntzen

Assignees

@LiviaValenti LiviaValenti

Labels
backend 🍑 Backend tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix admission-status backend authorization
2 participants
@LiviaValenti @Xtrah