-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: filter and sort backend #68
Conversation
fe8b04b
to
18c9776
Compare
feca98b
to
1624e7b
Compare
I can't seem to find the possibility to assign you as reviewer @Xtrah as you created this PR. So this tag represents a request for review 🤺 |
5176852
to
75a2829
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't get this solution to work. The name-filter partially work, committee-filter don't work, status-filter partially work, and sort dosn't work. I tested through Postman. When I say don't work/partially work, I mean that it either returns all applications, or some applications, but not the right ones, or no applications at all, even though it should return at least one
Outdated:Current:
|
* lacks conditional parameters * lacks sorting on name and date * pagination does not work * array of committees does not work
* adjust frontend for new pagination format
* minor improvements to comments * changed order of query validation
041f482
to
297fcc2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice jobs! Works as expected
297fcc2
to
8a1cbad
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazeballs 🤩
Closes #56
Summary of changes
Filter applications based on queries
/applications?name=[query]
/applications?status=[status]
status: all possible statuses (is also validated) e.g. Pending/applications?sort=[sort_attribute]
sort_attribute: name_asc, name_desc, date_asc, date_desc/applications?committee=[committeeID]
can be repeated e.g. (committee=3&committee=10)This also includes validation of queries,: