Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: dashboard #69

Merged
merged 15 commits into from
Apr 20, 2022
Merged

feat: dashboard #69

merged 15 commits into from
Apr 20, 2022

Conversation

supapesh
Copy link
Contributor

@supapesh supapesh commented Apr 6, 2022

Closes #49

Summary of changes

  • Add Metrobox-style boxes to fit Figma-sketches
  • Add styling to said boxes with correct logos
  • Add text that notifies whether or not period is open; if open, display from to end-date for period. If not open, notify user.
  • Add responsive design (not perfect🥺)

Preview

Animation

@supapesh supapesh added the frontend ✨ Frontend tasks label Apr 6, 2022
@supapesh supapesh added this to the Sprint 3 milestone Apr 6, 2022
@supapesh supapesh self-assigned this Apr 6, 2022
@supapesh supapesh force-pushed the dashboard_frontend_49 branch 2 times, most recently from a65423d to 8d3e09f Compare April 7, 2022 11:23
@LiviaValenti LiviaValenti changed the title feat: dashboard according to Figma-sketches feat: dashboard Apr 7, 2022
HenrikVL
HenrikVL requested changes Apr 8, 2022
View reviewed changes
Copy link
Collaborator

@HenrikVL HenrikVL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the dashboard looks great! I have a few styling suggestions that you can consider implementing. Other than that I think you have done a really good job!

frontend/src/pages/Dashboard.tsx Outdated Show resolved Hide resolved
frontend/src/pages/Dashboard.tsx Show resolved Hide resolved
frontend/src/pages/Dashboard.tsx Outdated Show resolved Hide resolved
frontend/src/pages/Dashboard.tsx Outdated Show resolved Hide resolved
frontend/src/pages/Dashboard.tsx Show resolved Hide resolved
frontend/src/pages/Dashboard.tsx Outdated Show resolved Hide resolved
@Xtrah Xtrah requested a review from HenrikVL April 11, 2022 12:08
@supapesh supapesh force-pushed the dashboard_frontend_49 branch from 0c517bb to 5f3b59d Compare April 11, 2022 17:51
LiviaValenti
LiviaValenti requested changes Apr 12, 2022
View reviewed changes
Copy link
Collaborator

@LiviaValenti LiviaValenti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR still lacks one element (retrieval of first and last name). Otherwise it looks and works well! ⭐

frontend/src/pages/Dashboard.tsx Outdated Show resolved Hide resolved
frontend/src/pages/Dashboard.tsx Outdated Show resolved Hide resolved
frontend/src/pages/Dashboard.tsx Show resolved Hide resolved
@LiviaValenti LiviaValenti mentioned this pull request Apr 14, 2022
Merged
@supapesh supapesh force-pushed the dashboard_frontend_49 branch from 838fe64 to dc08342 Compare April 18, 2022 13:48
@supapesh supapesh requested a review from LiviaValenti April 18, 2022 14:22
HenrikVL
HenrikVL approved these changes Apr 19, 2022
View reviewed changes
Copy link
Collaborator

@HenrikVL HenrikVL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve! I think I would change the fontWeight of the name on the dashboard, but otherwise it looks great!

frontend/src/pages/Dashboard.tsx Outdated Show resolved Hide resolved
@supapesh supapesh force-pushed the dashboard_frontend_49 branch from a7312be to 2c678b1 Compare April 20, 2022 10:00
@Xtrah
Copy link
Member

Xtrah commented Apr 20, 2022

@LiviaValenti Changes are complete, can you take a final look?

@Xtrah Xtrah requested review from LiviaValenti and removed request for LiviaValenti April 20, 2022 10:29
@supapesh supapesh force-pushed the dashboard_frontend_49 branch from 6b8c7f7 to 409db91 Compare April 20, 2022 16:45
LiviaValenti
LiviaValenti approved these changes Apr 20, 2022
View reviewed changes
Copy link
Collaborator

@LiviaValenti LiviaValenti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed (as agreed upon) some improvements with transitions as well as a tiny fix I caught in StatusInput 🦅

For the rest you have done an awesome job, it'll be super refreshing to see the dashboard now! 🏁

@supapesh supapesh force-pushed the dashboard_frontend_49 branch from 342948b to 738c98b Compare April 20, 2022 22:04
@supapesh supapesh merged commit d47ed5e into dev Apr 20, 2022
@supapesh supapesh deleted the dashboard_frontend_49 branch April 20, 2022 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xtrah Xtrah Xtrah left review comments

@LiviaValenti LiviaValenti LiviaValenti approved these changes

@HenrikVL HenrikVL HenrikVL approved these changes

Assignees

@supapesh supapesh

Labels
frontend ✨ Frontend tasks
Projects
None yet
Milestone
Sprint 3
Development

Successfully merging this pull request may close these issues.

Dashboard
4 participants
@supapesh @Xtrah @HenrikVL @LiviaValenti