Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: publish package #74

Merged
merged 9 commits into from
Apr 22, 2022
Merged

feat: publish package #74

merged 9 commits into from
Apr 22, 2022

Conversation

Xtrah
Copy link
Member

@Xtrah Xtrah commented Apr 13, 2022 •
edited
Loading

Closes #71

Summary of changes

Extracts package to its own repository, published it, and installs it from the npm registry.

Testing changes

  1. Delete all node_modules folders
  2. Make sure /package folder is deleted
  3. Run backend and make sure everything works and runs as expected when package is installed from npmjs registry

Known issues

The package is currently hardcoded to use dev.api.ntnui.no 😬

@Xtrah Xtrah self-assigned this Apr 13, 2022
@supapesh
Copy link
Contributor

I remember having huge issues when exporting when we did IT2810. Something something with the whole importing and exporting procedure with ES6. Perhaps this can help?
https://stackoverflow.com/questions/69153621/syntaxerror-unexpected-token-export-while-exporting-function-js

@Xtrah Xtrah marked this pull request as ready for review April 19, 2022 11:27
@Xtrah Xtrah force-pushed the feat/publish-package branch from c6155ed to bd06abc Compare April 19, 2022 11:49
@Xtrah Xtrah force-pushed the feat/publish-package branch from bd06abc to 9c9bebd Compare April 19, 2022 11:49
@Xtrah Xtrah force-pushed the feat/publish-package branch from 9c9bebd to 705f18d Compare April 19, 2022 11:51
@Xtrah Xtrah removed their assignment Apr 19, 2022
@Xtrah Xtrah added the backend 🍑 Backend tasks label Apr 19, 2022
@Xtrah Xtrah force-pushed the feat/publish-package branch from e92c264 to 479995e Compare April 22, 2022 10:57
SanderArntzen
SanderArntzen approved these changes Apr 22, 2022
View reviewed changes
Copy link
Contributor

@SanderArntzen SanderArntzen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything runs as expected 👍

LiviaValenti
LiviaValenti approved these changes Apr 22, 2022
View reviewed changes
Copy link
Collaborator

@LiviaValenti LiviaValenti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works bjutifully✨

We should add the possibility to change the api-source for local development of support apps. For the rest it is a really solid piece of work 🗿 🧱

Great work 🤱🏼

backend/package.json Outdated Show resolved Hide resolved
@Xtrah Xtrah merged commit 12fb7b9 into dev Apr 22, 2022
@Xtrah Xtrah deleted the feat/publish-package branch April 22, 2022 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SanderArntzen SanderArntzen SanderArntzen approved these changes

@LiviaValenti LiviaValenti LiviaValenti approved these changes

Assignees
No one assigned
Labels
backend 🍑 Backend tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Publish package
4 participants
@Xtrah @supapesh @LiviaValenti @SanderArntzen