Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: wipe admission data frontend #79

Merged
merged 8 commits into from
Apr 22, 2022
Merged

feat: wipe admission data frontend #79

merged 8 commits into from
Apr 22, 2022

Conversation

LiviaValenti
Copy link
Collaborator

@LiviaValenti LiviaValenti commented Apr 20, 2022 •
edited
Loading

Closes #77

Summary of changes

  • Button on dashboard
  • Modal with information and confirmation-box
  • Minor fix to application period active 404
  • Authenticated routing

image

image

@LiviaValenti LiviaValenti added the frontend ✨ Frontend tasks label Apr 20, 2022
@LiviaValenti LiviaValenti self-assigned this Apr 20, 2022
HenrikVL
HenrikVL reviewed Apr 21, 2022
View reviewed changes
Copy link
Collaborator

@HenrikVL HenrikVL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The draft looks good! I added some feedback regarding styling. The logic looks good 💃

frontend/src/components/WipeAdmissionDataModal.tsx Outdated Show resolved Hide resolved
@LiviaValenti LiviaValenti marked this pull request as ready for review April 21, 2022 21:27
@LiviaValenti LiviaValenti requested review from HenrikVL and Xtrah April 21, 2022 21:30
@LiviaValenti LiviaValenti force-pushed the feat/wipe-admission-data-frontend branch from 274b933 to b1dcac6 Compare April 22, 2022 10:44
@LiviaValenti LiviaValenti requested a review from supapesh April 22, 2022 16:31
Xtrah
Xtrah approved these changes Apr 22, 2022
View reviewed changes
Copy link
Member

@Xtrah Xtrah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super!

frontend/src/components/WipeAdmissionDataModal.tsx Show resolved Hide resolved
supapesh
supapesh approved these changes Apr 22, 2022
View reviewed changes
Copy link
Contributor

@supapesh supapesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than some small comments, I think it's very good. I approve🤩

frontend/src/components/WipeAdmissionDataModal.tsx Outdated Show resolved Hide resolved
frontend/src/components/WipeAdmissionDataModal.tsx Outdated Show resolved Hide resolved
@LiviaValenti LiviaValenti force-pushed the feat/wipe-admission-data-frontend branch from b4a7996 to 31d7d43 Compare April 22, 2022 20:35
@LiviaValenti LiviaValenti merged commit 13978f6 into dev Apr 22, 2022
@LiviaValenti LiviaValenti deleted the feat/wipe-admission-data-frontend branch April 22, 2022 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@supapesh supapesh supapesh approved these changes

@Xtrah Xtrah Xtrah approved these changes

@HenrikVL HenrikVL Awaiting requested review from HenrikVL

Assignees

@LiviaValenti LiviaValenti

Labels
frontend ✨ Frontend tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wipe application data frontend
4 participants
@LiviaValenti @Xtrah @HenrikVL @supapesh