fix "nothing?callback=onJSONP_Data" 404 (Not Found) error #814
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to update recline and timemapper to the most recent TimelineJS, i was getting a 404 (Not Found) error relating to a final getJSON call to "nothing?callback=onJSONP_Data"
Investigation showed that the data was already received, but not being added to the config.source, which resulted in a call to "nothing" the default source on the config object.
additionally I changed to the ajax call rather than getJSON based on the advice of the article that I cited in the comment:
http://stackoverflow.com/questions/1002367/jquery-ajax-jsonp-ignores-a-timeout-and-doesnt-fire-the-error-event
This seemed to work inside timemapper, but broke the timelineJS test:
http://recline.1zm.in/vendor/TimelineJS2/tests/test_extra_html.html
So i rolled it back to still use getJSON... I left the comment in there to start a discussion... what are the advantages of getJSON? do you agree in general with the advice from Husky on that stackoverflow link?
cheers,
gotjoshua